[core] Fix std::flush with istream::readsome
#50248
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dentiny
force-pushed
the
hjiang/pipe-readsome
branch
from
d637a3a to
bc19684
Compare
Signed-off-by: dentiny <[email protected]>
dentiny
force-pushed
the
hjiang/pipe-readsome
branch
from
bc19684 to
0953813
Compare
jjyao
reviewed
Feb 5, 2025
dentiny
force-pushed
the
hjiang/pipe-readsome
branch
from
681e78f to
059d963
Compare
Signed-off-by: dentiny <[email protected]>
dentiny
force-pushed
the
hjiang/pipe-readsome
branch
from
059d963 to
f25d458
Compare
Signed-off-by: dentiny <[email protected]>
|
@jjyao I updated the implementation and integrate with the newliner sink, no known stuck issue at the moment. |
Signed-off-by: dentiny <[email protected]>
Signed-off-by: dentiny <[email protected]>
dentiny
force-pushed
the
hjiang/pipe-readsome
branch
from
4b96c9b to
9d2ebc3
Compare
Signed-off-by: dentiny <[email protected]>
jjyao
reviewed
Feb 10, 2025
Signed-off-by: dentiny <[email protected]>
Signed-off-by: dentiny <[email protected]>
jjyao
reviewed
Feb 11, 2025
| std::this_thread::sleep_for(std::chrono::seconds(2)); | ||
| FlushOnRedirectedStderr(); | ||
|
|
||
| // Make sure flush hook works fine and process terminates with no problem. |
There was a problem hiding this comment.
we are not checking anything here?
There was a problem hiding this comment.
See documentation above.
// This test case only checks whether stream redirection process could exit normally.
| StreamRedirectionOption opts; | ||
| opts.file_path = test_file_path; | ||
| opts.tee_to_stderr = true; | ||
| RedirectStderr(opts); |
There was a problem hiding this comment.
Can we decouple RedirectStream with atexit() so that we can test better and don't need to create a file for each test.
Ideally we can manually call SyncOnStreamRedirection to close the redirection.
RedirectStderr();
// test
SyncOnStreamRedirection(); // restore to the old state
// some checks
RedirectStderr();
// another test
SyncOnStreamRedirection();
// some checks
There was a problem hiding this comment.
That way you need to return redirection handler to the caller? Or return the exit terminator.
Signed-off-by: dentiny <[email protected]>
Signed-off-by: dentiny <[email protected]>
dentiny
force-pushed
the
hjiang/pipe-readsome
branch
from
87dee19 to
babd0bb
Compare
jjyao
approved these changes
Feb 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current implementation doesn't handle
std::flush, which requires to dump content into sinks right away.This PR reads content from pipe in two ways:
istream::readsometo apply non-blocking read, to read all content right away;istream::readto block read, so we don't waste CPU cycle on busy polling when no content in pipe.