Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] Move ray.experimental.tf_utils back to rllib #51183

Open
wants to merge 11 commits into
base: master
Choose a base branch
from

Conversation

edoakes
Copy link
Collaborator

@edoakes edoakes commented Mar 8, 2025

Why are these changes needed?

We have an experimental tensorflow utils library that was moved out of rllib and into core in 2019 (thread: #5698).

The way it's written makes Ray depend on RLlib (circular dependency). We could refactor this code to move the other related utils into Ray, but as far as I can tell, outside of rllib, this code was only used in an example from the documentation that was removed in 2022: #24727 (some of the code was missed, I'm removing it here).

We do not expose it in our documentation at all and it lives under experimental, so should be safe to remove.

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

Signed-off-by: Edward Oakes <[email protected]>
@edoakes edoakes requested a review from a team as a code owner March 8, 2025 13:28
@edoakes edoakes added the go add ONLY when ready to merge, run all tests label Mar 8, 2025
@edoakes
Copy link
Collaborator Author

edoakes commented Mar 8, 2025

@richardliaw PTAL and let me know if there's a concern I'm missing

Signed-off-by: Edward Oakes <[email protected]>
@edoakes edoakes changed the title [core] Remove ray.experimental.tf_utils [core] Move ray.experimental.tf_utils back to rllib Mar 8, 2025
edoakes added 5 commits March 8, 2025 07:46
Signed-off-by: Edward Oakes <[email protected]>
Signed-off-by: Edward Oakes <[email protected]>
Signed-off-by: Edward Oakes <[email protected]>
Signed-off-by: Edward Oakes <[email protected]>
Signed-off-by: Edward Oakes <[email protected]>
Signed-off-by: Edward Oakes <[email protected]>
return arrays


@DeveloperAPI
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if this is right, lmk @sven1977 @simonsays1980

As far as I can tell we don't even have public docs for the tf_utils, so not sure if they're used

edoakes added 3 commits March 8, 2025 08:23
Signed-off-by: Edward Oakes <[email protected]>
Signed-off-by: Edward Oakes <[email protected]>
Signed-off-by: Edward Oakes <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
go add ONLY when ready to merge, run all tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant