-
Notifications
You must be signed in to change notification settings - Fork 6.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[core] Move ray.experimental.tf_utils
back to rllib
#51183
Open
edoakes
wants to merge
11
commits into
ray-project:master
Choose a base branch
from
edoakes:eoakes/rm-tf-utils
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Edward Oakes <[email protected]>
@richardliaw PTAL and let me know if there's a concern I'm missing |
Signed-off-by: Edward Oakes <[email protected]>
ray.experimental.tf_utils
ray.experimental.tf_utils
back to rllib
Signed-off-by: Edward Oakes <[email protected]>
Signed-off-by: Edward Oakes <[email protected]>
Signed-off-by: Edward Oakes <[email protected]>
Signed-off-by: Edward Oakes <[email protected]>
Signed-off-by: Edward Oakes <[email protected]>
8 tasks
Signed-off-by: Edward Oakes <[email protected]>
edoakes
commented
Mar 8, 2025
return arrays | ||
|
||
|
||
@DeveloperAPI |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure if this is right, lmk @sven1977 @simonsays1980
As far as I can tell we don't even have public docs for the tf_utils
, so not sure if they're used
Signed-off-by: Edward Oakes <[email protected]>
Signed-off-by: Edward Oakes <[email protected]>
Signed-off-by: Edward Oakes <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
We have an experimental tensorflow utils library that was moved out of
rllib
and into core in 2019 (thread: #5698).The way it's written makes Ray depend on RLlib (circular dependency). We could refactor this code to move the other related utils into Ray, but as far as I can tell, outside of
rllib
, this code was only used in an example from the documentation that was removed in 2022: #24727 (some of the code was missed, I'm removing it here).We do not expose it in our documentation at all and it lives under
experimental
, so should be safe to remove.Related issue number
Checks
git commit -s
) in this PR.scripts/format.sh
to lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/
under thecorresponding
.rst
file.