improved UX, so users don't need to hunt the ouath url in the logs#2
Merged
improved UX, so users don't need to hunt the ouath url in the logs#2
Conversation
…ow it opens the default browser when needed
There was a problem hiding this comment.
Pull Request Overview
This PR enhances the OAuth authentication process by introducing automatic browser launching functionality. The main improvement is that users no longer need to manually copy-paste OAuth URLs from logs, as the system now automatically opens the URL in their default browser with a fallback to console display.
Key changes:
- Introduces
BrowserLauncherServicewith automatic browser opening and fallback mechanisms - Updates OAuth flow to integrate browser launching before waiting for authentication
- Updates project version to 1.1.0 with corresponding documentation
Reviewed Changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/utils/browser-launcher.ts | New service implementing browser launching with fallback strategies |
| src/services/auth.ts | Integration of browser launcher into OAuth authentication flow |
| src/services/oauth-server.ts | Refactored to separate URL generation from auth flow execution |
| package.json | Version bump to 1.1.0 and added 'open' dependency with build externalization |
| README.md | Updated documentation highlighting new auto-browser feature and changelog |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces a significant enhancement to the OAuth authentication process by adding automatic browser launching with a fallback mechanism, improving user experience and error handling. It also updates the project version to
1.1.0and includes related dependency and documentation updates.Enhancements to OAuth Flow:
BrowserLauncherService, which attempts to open the OAuth URL in the default system browser. If this fails, it gracefully falls back to displaying the URL in the console for manual access. (src/utils/browser-launcher.ts,src/services/auth.ts,src/services/oauth-server.ts) [1] [2] [3] [4]src/utils/browser-launcher.ts)Documentation Updates:
1.1.0. (README.md) [1] [2]Dependency and Configuration Updates:
openpackage to enable browser launching. (package.json)openpackage. (package.json)These changes collectively improve the usability and robustness of the OAuth flow, making the application more user-friendly and reliable.