Cache unchanged files on dry run v2 #4281
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dorrogeray
force-pushed
the
cache-unchanged-files-on-dry-run-v2
branch
4 times, most recently
from
f037236 to
34062bc
Compare
samsonasik
reviewed
Jun 19, 2023
dorrogeray
force-pushed
the
cache-unchanged-files-on-dry-run-v2
branch
3 times, most recently
from
b6e744a to
e4f9015
Compare
samsonasik
approved these changes
Jun 19, 2023
|
@samsonasik I have created a matrix to run the consecutive test with cache with dry run both with and without parallelization: https://github.com/rectorphp/rector-src/actions/runs/5314204113/jobs/9621140293?pr=4281 |
|
@TomasVotruba e2e workflow update may need to be enabled: |
dorrogeray
force-pushed
the
cache-unchanged-files-on-dry-run-v2
branch
from
23da35d to
f7bba1a
Compare
|
I'll review this now... |
|
Thank you @dorrogeray 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rework of #3834
PR for issue rectorphp/rector#7932
The idea is to cache unchanged files on --dry-run, so subsequent --dry-runs can be faster, while always producing same results.