Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix] the test for the package versions on images #1923

Merged
merged 1 commit into from
Oct 14, 2024
Merged

[Fix] the test for the package versions on images #1923

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions ods_ci/tests/Resources/Page/ODH/JupyterHub/JupyterLabLauncher.robot
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -453,7 +453,6 @@
Check Versions In JupyterLab
[Arguments] ${libraries-to-check}
${return_status} = Set Variable PASS
@{packages} = Create List Python Boto3 Kafka-Python Matplotlib Scikit-learn Pandas Scipy Numpy
FOR ${libString} IN @{libraries-to-check}
# libString = LibName vX.Y -> libDetail= [libName, X.Y]
@{libDetail} = Split String ${libString} ${SPACE}v
Expand Down Expand Up @@ -531,12 +530,18 @@
${return_status} = Set Variable FAIL
END
END

# Now check that selected list of packages has same version among all the images.
@{packages} = Create List Python Boto3 Kafka-Python Scipy

Check notice

Code scanning / Robocop

{{ create_keyword }} can be replaced with VAR Note test

Create List can be replaced with VAR

Continue For Loop If "${libDetail}[0]" not in ${packages}
IF "${libDetail}[0]" not in ${package_versions}
... Set To Dictionary ${package_versions} ${libDetail}[0]=${libDetail}[1]
IF "${package_versions["${libDetail}[0]"]}" != "${libDetail}[1]"
${return_status} = Set Variable FAIL
Run Keyword And Continue On Failure FAIL "${package_versions["${libDetail}[0]"]} != ${libDetail}[1]"
Run Keyword And Continue On Failure Fail
... Version of this library in this image doesn't align with versions in other images
... "${package_versions["${libDetail}[0]"]} != ${libDetail}[1]"
END
END
RETURN ${return_status}
Expand Down
Loading