[Fix] the test for the package versions on images #1923
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jstourac
added
verified
Robot Results
|
3 tasks
In the second part of this test, we have a selected list of packages so that we expect these packages to be same version amongst all the tested images. We have to reduce this list as now there are more packages that are expected not to be in the same version as was in past.
jstourac
force-pushed
the
fixVersionsTest
branch
from
a5bbc93
to
b1583d2
Compare
|
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -531,12 +530,18 @@ | |||
| ${return_status} = Set Variable FAIL | |||
| END | |||
| END | |||
|
|
|||
| # Now check that selected list of packages has same version among all the images. | |||
| @{packages} = Create List Python Boto3 Kafka-Python Scipy | |||
Check notice
Code scanning / Robocop
{{ create_keyword }} can be replaced with VAR Note test
|
Just rebased so that we can see the GHA are truly green. |
jiridanek
approved these changes
Oct 14, 2024
CFSNM
approved these changes
Oct 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the second part of this test, we have a selected list of packages so that we expect these packages to be same version amongst all the tested images. We have to reduce this list as now there are more packages that are expected not to be in the same version as was in past.
CI:
The failed tests are expected and will be fixed once this fix opendatahub-io/notebooks#742 is propagated into the product.