Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

controllers: set clientProfile name in mapping #293

Merged

Conversation

rewantsoni
Copy link
Member

set the client profile name in the mapping cr to be a hash of storageclaim name till we move to a single clientProfile for the entire client

@rewantsoni
Copy link
Member Author

Testing, the clientProfileMapping has the local and remote clientProfile set to storageClaimHash

[rewantsoni scripts] k get clientprofilemappings.csi.ceph.io -oyaml
apiVersion: v1
items:
- apiVersion: csi.ceph.io/v1alpha1
  kind: ClientProfileMapping
  metadata:
    creationTimestamp: "2024-12-02T06:22:01Z"
    generation: 2
    name: ocs-storagecluster
    namespace: openshift-storage
    ownerReferences:
    - apiVersion: ocs.openshift.io/v1alpha1
      kind: StorageClient
      name: ocs-storagecluster
      uid: 1e99f74c-0ac7-419f-a4ca-587855a0bc17
    resourceVersion: "45387051"
    uid: bb4c922f-00e7-4101-8a6b-ce32d15e8435
  spec:
    mappings:
    - blockPoolIdMapping:
      - - "1"
        - "1"
      localClientProfile: 81fd58def37a35d1b4d4bee7ba35c3c3
      remoteClientProfile: 81fd58def37a35d1b4d4bee7ba35c3c3
kind: List
metadata:
  resourceVersion: ""

set the client profile name in the mapping cr to be a hash of
storageclaim name till we move to a single clientProfile for
the entire client

Signed-off-by: Rewant Soni <[email protected]>
@nb-ohad
Copy link
Contributor

nb-ohad commented Dec 10, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Dec 10, 2024
Copy link

openshift-ci bot commented Dec 10, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nb-ohad, rewantsoni

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rewantsoni
Copy link
Member Author

/jira cherrypick release-4.18

@openshift-merge-bot openshift-merge-bot bot merged commit 273a0c9 into red-hat-storage:main Dec 10, 2024
10 checks passed
@rewantsoni
Copy link
Member Author

/jira backport release-4.18

@rewantsoni
Copy link
Member Author

/cherrypick release-4.18

@openshift-cherrypick-robot

@rewantsoni: new pull request created: #294

In response to this:

/cherrypick release-4.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants