Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DFBUGS-1025: [release-4.18] controllers: set clientProfile name in mapping #294

Conversation

openshift-cherrypick-robot

This is an automated cherry-pick of #293

/assign rewantsoni

set the client profile name in the mapping cr to be a hash of
storageclaim name till we move to a single clientProfile for
the entire client

Signed-off-by: Rewant Soni <[email protected]>
@rewantsoni
Copy link
Member

rewantsoni commented Dec 10, 2024

/retitle DFBUGS-1025: [release-4.18] controllers: set clientProfile name in mapping

@openshift-ci openshift-ci bot changed the title [release-4.18] controllers: set clientProfile name in mapping DFBUGS-1025: [release-4.18] controllers: set clientProfile name in mapping Dec 10, 2024
@openshift-ci-robot openshift-ci-robot added jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid jira ticket of any type jira/invalid-bug Indicates that the referenced jira bug is invalid for the branch this PR is targeting labels Dec 10, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Dec 10, 2024

@openshift-cherrypick-robot: This pull request references [Jira Issue DFBUGS-1025](https://issues.redhat.com//browse/DFBUGS-1025), which is invalid:

  • expected the bug to target the "odf-4.18" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

This is an automated cherry-pick of #293

/assign rewantsoni

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@rewantsoni
Copy link
Member

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that the referenced jira bug is valid for the branch this PR is targeting and removed jira/invalid-bug Indicates that the referenced jira bug is invalid for the branch this PR is targeting labels Dec 10, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Dec 10, 2024

@rewantsoni: This pull request references [Jira Issue DFBUGS-1025](https://issues.redhat.com//browse/DFBUGS-1025), which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (odf-4.18) matches configured target version for branch (odf-4.18)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@leelavg
Copy link
Contributor

leelavg commented Dec 10, 2024

/lgtm

Copy link

openshift-ci bot commented Dec 10, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: leelavg, openshift-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit f0df324 into red-hat-storage:release-4.18 Dec 10, 2024
11 checks passed
@openshift-ci-robot
Copy link

openshift-ci-robot commented Dec 10, 2024

@openshift-cherrypick-robot: [Jira Issue DFBUGS-1025](https://issues.redhat.com//browse/DFBUGS-1025): All pull requests linked via external trackers have merged:

[Jira Issue DFBUGS-1025](https://issues.redhat.com//browse/DFBUGS-1025) has been moved to the MODIFIED state.

In response to this:

This is an automated cherry-pick of #293

/assign rewantsoni

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-bug Indicates that the referenced jira bug is valid for the branch this PR is targeting jira/valid-reference Indicates that this PR references a valid jira ticket of any type lgtm size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants