Plugin auto installation when operator is installed #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shirmoran
force-pushed
the
plugin-installation
branch
2 times, most recently
from
851bfa0 to
2da4a3b
Compare
shirmoran
force-pushed
the
plugin-installation
branch
from
cf825b2 to
9b42c8c
Compare
greyerof
reviewed
Jul 17, 2024
bundle/manifests/cnf-certsuite-operator.clusterserviceversion.yaml
Outdated
Show resolved
Hide resolved
plugin/consolePlugin.yaml
Outdated
| service: | ||
| basePath: / | ||
| name: cnf-certsuite-plugin | ||
| namespace: cnf-certsuite-operator |
There was a problem hiding this comment.
This hardcoded namespace on all these plugin's resources must be changed in the controller's code before the err = r.Create(context.Background(), obj.(client.Object)). Otherwise, it won't work if the operator's subscription is created in a different namespace.
This can be done in a following PR, though.
greyerof
approved these changes
Jul 18, 2024
shirmoran
merged commit a186da3
into
redhat-best-practices-for-k8s:main
3 checks passed
This was referenced Jul 31, 2024
shirmoran
added a commit
that referenced
this pull request
Aug 5, 2024
Based on [this](#89 (comment)) discussion in previous PR, Instead of using a hard coded ns for the console plugin, the plugin ns will be set according to the ns of the controller. The controller ns is saved as an env var within the container using [downward API](https://github.com/kubernetes/kubernetes/blob/release-1.0/docs/user-guide/downward-api.md). That way, when setting up controller's manager and creating the plugin resources, we can extract the controller's ns and set it as the console plugin ns as well. The plugin resources don't have a default ns, and are set with a place holder for the ns. That way, if we fail to set the operator ns as the plugins ns, will get back an error.
shirmoran
added a commit
that referenced
this pull request
Aug 5, 2024
Addressing [this](#89 (comment)) discussion in previous PR. For terms of consistency we'll use only the `kubectl` command instead of `oc` command when running workflows using a kind cluster.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes in this PR will make the console plugin of the operator be auto-installed whenever the operator is installed.
This PR allows the plugin installation through the operator using both OLM and the manual installation of the operator.
Plugin resources can be found at the
plugindirectory.Next step: auto delete plugin's resources when the operator is deleted.