datalake/metrics: miscellaneous improvements to lag metrics #24568
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/dt |
Retry command for Build#59736please wait until all jobs are finished before running the slash command |
CI test resultstest results on build#59736
test results on build#59747
test results on build#59767
|
andrwng
previously approved these changes
Dec 13, 2024
rockwotj
previously approved these changes
Dec 14, 2024
| @@ -168,14 +180,19 @@ void replicated_partition_probe::setup_internal_metrics(const model::ntp& ntp) { | |||
| {sm::shard_label, partition_label}); | |||
|
|
|||
| if (model::is_user_topic(_partition.ntp())) { | |||
| // Metrics are reported as follows | |||
| // -2 (default initialized state) | |||
There was a problem hiding this comment.
can we add this to the public description too for downstream systems?
Retry command for Build#59747please wait until all jobs are finished before running the slash command |
This is based on our experience debugging Brandon's perf setup. - Changes the metric reporting to report lag only on leaders. This makes it easy to monitor the metric using an aggregate across all replicas without having to worry about the current leader. - Fixed a bug where lag entry was not added to serde fields, adjusted the test coverage to catch this scenario, refactored the test slightly while I'm there.
bharathv
force-pushed
the
lag_metric_changes
branch
from
6b976a0 to
bef3254
Compare
rockwotj
approved these changes
Dec 14, 2024
Retry command for Build#59767please wait until all jobs are finished before running the slash command |
|
/backport v24.3.x |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is based on our experience debugging Brandon's perf setup.
Changes the metric reporting to report lag only on leaders. This makes it easy to monitor the metric using an aggregate across all replicas without having to worry about the current leader.
Fixed a bug where lag entry was not added to serde fields, adjusted the test coverage to catch this scenario, refactored the test slightly while I'm there.
Backports Required
Release Notes
Bug Fixes