[v24.2.x] Validate offset delta in append entries handler #24703
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added a `prev_log_delta` field to `raft::protocol_metadata`. The `prev_log_delta` contains an offset translator delta corresponding to metadata `prev_log_index`. Including the delta in metadata will allow follower to detect offset translator state inconsistency. Signed-off-by: Michał Maślanka <[email protected]> (cherry picked from commit ff96d02)
Added offset translator state validation to append entries handler. The validation doesn't prevent Raft group from operation but emits an error log message which can be easily observed. Signed-off-by: Michał Maślanka <[email protected]> (cherry picked from commit 97d3d4f)
Signed-off-by: Michał Maślanka <[email protected]> (cherry picked from commit 3dc5470)
|
Fixes: #24633 |
|
/ci-repeat 1 |
bashtanov
approved these changes
Jan 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of PR #24617