Lean: add support for register definitions #894
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This does break the output of bitfields to some extent, since there is no support for derefs yet |
javra
reviewed
Jan 17, 2025
| hardline; | ||
| string " get_"; | ||
| idd; | ||
| colon; |
There was a problem hiding this comment.
Space needed before the colon
| idd; | ||
| colon; | ||
| space; | ||
| string "SailM ("; |
There was a problem hiding this comment.
The brackets for the argument of SailM are not needed because whoever produces a composite term should be in charge of bracketing (in this case doc_typ).
|
|
||
| open Sail | ||
|
|
||
| class MonadReg where |
There was a problem hiding this comment.
Shouldn't the register state be part of the state that's carried by SailM? That would give us the getter and setter "for free" instead? Or do we want to keep this flexible? What's your opinion on this, @bacam ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.