Port codegen arrow deserialization to arrow-rs #8375
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emilk
added
🏹 arrow
|
Web viewer built successfully. If applicable, you should also test it:
Note: This comment is updated whenever you push a commit. |
emilk
force-pushed
the
emilk/arrow-deserializer
branch
2 times, most recently
from
f84e718 to
3e792d2
Compare
|
@rerun-bot full-check |
|
Started a full build: https://github.com/rerun-io/rerun/actions/runs/12410292950 |
abey79
changed the title
|
Heads up: full check is failing |
emilk
force-pushed
the
emilk/arrow-deserializer
branch
from
10d58b6 to
478e038
Compare
emilk
force-pushed
the
emilk/arrow-deserializer
branch
from
478e038 to
9c5fd70
Compare
|
@rerun-bot full-check |
|
Started a full build: https://github.com/rerun-io/rerun/actions/runs/12634086171 ✅ |
emilk
force-pushed
the
emilk/arrow-deserializer
branch
from
25ee716 to
77e4543
Compare
teh-cmc
approved these changes
Jan 7, 2025
Comment on lines
+351
to
+360
| // `.child()` will panic if the given `type_id` doesn't exist, | ||
| // which could happen if the number of union arms has changed | ||
| // between serialization and deserialization. | ||
| // There is no simple way to check for this using `arrow-rs` | ||
| // (no access to `UnionArray::fields` as of arrow 54: | ||
| // https://docs.rs/arrow/latest/arrow/array/struct.UnionArray.html) | ||
| // | ||
| // Still, we're planning on removing arrow unions entirely, so this is… fine. | ||
| // TODO(#6388): stop using arrow unions, and remove this peril | ||
| let #data_src = #data_src.child(#type_id).as_ref(); |
There was a problem hiding this comment.
Why not keep the existing if-statement that helped with forward compat though?
There was a problem hiding this comment.
There was no obvious way how to make it work. There is no data_src_arrays anymore because there is no .fields() on UnionArray
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related
re_arrow2toarrow#3741Blocked by Add unsafe/unchecked slice functions apache/arrow-rs#6901TensorDimensioninto shape and names #6830TODO
@rerun-bot full-check