-
Notifications
You must be signed in to change notification settings - Fork 385
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Specify, test, and fix all broken AsComponents
<>ComponentBatch
interactions from blanket impls
#8591
Conversation
AsComponents/
ComponentBatch` interactions from blanket implsAsComponents
<>ComponentBatch
interactions from blanket impls
Web viewer built successfully. If applicable, you should also test it:
Note: This comment is updated whenever you push a commit. |
@rerun-bot full-check |
Started a full build: https://github.com/rerun-io/rerun/actions/runs/12637853276 |
@rerun-bot full-check |
Started a full build: https://github.com/rerun-io/rerun/actions/runs/12647234756 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oof tough! thanks for unraveling this knot!
729cd9a
to
d82fc66
Compare
Commit by commit is probably best.
Turns out cascading blanket impls on
&dyn T
are hard to reason about and don't do what you expect 🤪:C: Component
) should never be allowed to cast straight to a collection of batches (i.e.AsComponents
).This is the source of all the bugs. We need to enforce that this goes through a
ComponentBatch
first, which in turn will be auto-cast toAsComponents
.rec.log
).This was extremely dangerous: