Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify, test, and fix all broken AsComponents<>ComponentBatch interactions from blanket impls #8591

Merged
merged 9 commits into from
Jan 7, 2025
Merged

Specify, test, and fix all broken AsComponents<>ComponentBatch interactions from blanket impls #8591

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
1b5c20a
time to move AsComponents to its own file
teh-cmc Jan 6, 2025
51469fb
demonstrate all the many many problems
teh-cmc Jan 6, 2025
ae842be
a single component instance should never implement AsComponents directly
teh-cmc Jan 6, 2025
95062fb
re-express the previously broken tests in a way that now works properly
teh-cmc Jan 6, 2025
846a35e
remove the tests that will never be able to work
teh-cmc Jan 6, 2025
d140452
remove allows_ascomponents_unsized test, its body is now illegal
teh-cmc Jan 6, 2025
e8cbe68
typo
teh-cmc Jan 6, 2025
c43b6f0
propagate changes, which is very little
teh-cmc Jan 6, 2025
d82fc66
lints
teh-cmc Jan 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Cargo.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6531,6 +6531,7 @@ dependencies = [
"re_tracing",
"re_tuid",
"serde",
"similar-asserts",
"thiserror 1.0.65",
]

Expand Down
1 change: 1 addition & 0 deletions crates/store/re_types_core/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,7 @@ serde = { workspace = true, optional = true }

[dev-dependencies]
criterion.workspace = true
similar-asserts.workspace = true

[lib]
bench = false
Expand Down
Loading
Loading