-
Notifications
You must be signed in to change notification settings - Fork 385
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make all C++ archetypes eager serialized & provide generated update/clear APIs #8779
Open
Wumpf
wants to merge
23
commits into
main
Choose a base branch
from
andreas/cpp/more-eager
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wumpf
force-pushed
the
andreas/cpp/more-eager
branch
from
January 22, 2025 15:21
a79a4f3
to
728cf02
Compare
Wumpf
force-pushed
the
andreas/cpp/more-eager
branch
from
January 22, 2025 15:33
728cf02
to
95cd613
Compare
nope, only pushing a new commit fixed it. |
Web viewer built successfully. If applicable, you should also test it:
Note: This comment is updated whenever you push a commit. |
1 task
Wumpf
force-pushed
the
andreas/cpp/more-eager
branch
2 times, most recently
from
January 22, 2025 15:44
5335d4e
to
549d4b6
Compare
Wumpf
force-pushed
the
andreas/cpp/more-eager
branch
2 times, most recently
from
January 22, 2025 16:23
a6ae1e6
to
63f5486
Compare
Wumpf
force-pushed
the
andreas/cpp/more-eager
branch
from
January 22, 2025 16:40
63f5486
to
60da8d4
Compare
Wumpf
force-pushed
the
andreas/cpp/more-eager
branch
from
January 22, 2025 17:06
60da8d4
to
a9f8004
Compare
@rerun-bot full-check |
Started a full build: https://github.com/rerun-io/rerun/actions/runs/12913616811 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related
rerun::Collection
borrows data too eagerly, making it very easy to cause segfaults & read of invalid data #7081attr.cpp.archetype_eager
codegen attribute #8780What
(see title)
On every archetype in C++ you can now use
update_fields
&clear_fields
!Commit by commit recommended - most of them are trivial! Outstanding are:
tensor
with_dim_names
became quite hard. This is covered by a snippet (which I tested manually) but I also added a test nowvideo_asset
clear
=default
constructor as this one has its own (previous codegen wasn't as rigorous with default ctors!)main
ci