Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove attr.cpp.archetype_eager codegen attribute #8780

Merged
merged 2 commits into from
Jan 23, 2025
Merged

Conversation

Wumpf
Copy link
Member

@Wumpf Wumpf commented Jan 22, 2025

Related

What

Makes eager serialization & update/clear apis the norm in C++ with no opt out.

Also removes no longer needed warning suppression on builder methods!

  • said warning suppression is actually no longer needed on any compiler we test

@Wumpf Wumpf added do-not-merge Do not merge this PR 🚜 refactor Change the code, not the functionality codegen/idl 🌊 C++ API C/C++ API specific exclude from changelog PRs with this won't show up in CHANGELOG.md labels Jan 22, 2025
Copy link

github-actions bot commented Jan 22, 2025

Web viewer built successfully. If applicable, you should also test it:

  • I have tested the web viewer
Result Commit Link Manifest
31c006f https://rerun.io/viewer/pr/8780 +nightly +main

Note: This comment is updated whenever you push a commit.

@Wumpf Wumpf force-pushed the andreas/cpp/more-eager branch from 95cd613 to 5335d4e Compare January 22, 2025 15:41
@Wumpf Wumpf force-pushed the andreas/cpp/only-eager branch from 96a3b12 to 5675566 Compare January 22, 2025 15:41
@Wumpf Wumpf force-pushed the andreas/cpp/more-eager branch from 5335d4e to 549d4b6 Compare January 22, 2025 15:44
@Wumpf Wumpf force-pushed the andreas/cpp/only-eager branch from 5675566 to 185a42d Compare January 22, 2025 15:49
@Wumpf Wumpf force-pushed the andreas/cpp/more-eager branch 4 times, most recently from 60da8d4 to a9f8004 Compare January 22, 2025 17:06
@Wumpf Wumpf force-pushed the andreas/cpp/only-eager branch from 185a42d to 76d2278 Compare January 22, 2025 17:22
@Wumpf Wumpf marked this pull request as ready for review January 22, 2025 18:10
@teh-cmc teh-cmc self-requested a review January 23, 2025 08:19
Copy link
Member

@teh-cmc teh-cmc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Base automatically changed from andreas/cpp/more-eager to main January 23, 2025 08:59
@Wumpf
Copy link
Member Author

Wumpf commented Jan 23, 2025

We have unfortunately still other cases of that. I added a few again in the last, but yeah overall a lot less, gonna update that ticket a bit

@Wumpf Wumpf force-pushed the andreas/cpp/only-eager branch from 76d2278 to 31c006f Compare January 23, 2025 09:09
@Wumpf Wumpf removed the do-not-merge Do not merge this PR label Jan 23, 2025
@Wumpf Wumpf merged commit 67df6b1 into main Jan 23, 2025
38 of 39 checks passed
@Wumpf Wumpf deleted the andreas/cpp/only-eager branch January 23, 2025 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌊 C++ API C/C++ API specific codegen/idl exclude from changelog PRs with this won't show up in CHANGELOG.md 🚜 refactor Change the code, not the functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants