Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to pass http2.ServerOptions #219

Closed
wants to merge 1 commit into from
Closed

Allow to pass http2.ServerOptions #219

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 11 additions & 4 deletions src/server/restate_server.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,13 +138,17 @@ export class RestateServer extends BaseRestateServer {
* This method's result promise never completes.
*
* @param port The port to listen at. May be undefined (see above).
* @param http2ServerOptions The options to start the server with. If undefined, defaults from Node's HTTP2 server are used.
*/
public async listen(port?: number) {
public async listen(port?: number, http2ServerOptions?: http2.ServerOptions) {
// Infer the port if not specified, or default it
const actualPort = port ?? parseInt(process.env.PORT ?? "9080");
rlog.info(`Listening on ${actualPort}...`);

for await (const connection of incomingConnectionAtPort(actualPort)) {
for await (const connection of incomingConnectionAtPort(
actualPort,
http2ServerOptions
)) {
this.handleConnection(connection.url, connection.stream).catch((e) => {
const error = ensureError(e);
rlog.error(
Expand Down Expand Up @@ -190,8 +194,11 @@ export class RestateServer extends BaseRestateServer {
}
}

async function* incomingConnectionAtPort(port: number) {
const server = http2.createServer();
async function* incomingConnectionAtPort(
port: number,
http2ServerOptions?: http2.ServerOptions
) {
const server = http2.createServer(http2ServerOptions || {});

server.on("error", (err) =>
rlog.error("Error in Restate service endpoint http2 server: " + err)
Expand Down
Loading