-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
More code blocks added to the documentation + some spelling/minor fixes #35
base: main
Are you sure you want to change the base?
Conversation
If there are some block(s) that had a mistake in their .md file, please reply to me with them back. I know there are multiple blocks missing, but it's hard to keep up with the demand when you're only one person. |
Hi thanks for contributing, I'll take some time to review. |
Making some, or like, 1 quick revision(s) right now. I should've checked for some stuff, but I'll make sure to see your feedback soon. |
|
||
## Description | ||
|
||
Displays a colored chat bubble on a part object, with the specified message. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should match the block description.
@@ -0,0 +1,58 @@ | |||
--- | |||
description: Displays a colored chat bubble on a part object, with the specified message. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should match the block description.
@@ -0,0 +1,58 @@ | |||
--- | |||
description: Finds a path between the two positions. Returns a table of Vector3s, or a table with no elements if the path couldn't be computed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should match, or be part of the block description.
|
||
## Description | ||
|
||
Finds a path between the two positions. Returns a table of Vector3s, or a table with no elements if the path couldn't be computed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should match, or be part of the block description.
@@ -0,0 +1,53 @@ | |||
--- | |||
description: Deals damage to a character if they are not protected by a ForceField. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should match, or be part of the block description.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing property input.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would break this into client/server side specifically.
@@ -30,7 +30,7 @@ Runs the blocks connected to it when the given player starts holding down their | |||
|
|||
#### Player (Object) | |||
|
|||
You give the path to a Player. | |||
You give the path to a Player. *This input is only reserved for server scripts.* |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you rewrite this and remove the pronouns
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove your comments, make a bug report in the support server instead.
More code blocks added to the documentation + some spelling/minor fixes
My pull request is to
If adding documenation, I am adding it to
If adding documentation, did I
Additional information
Just making the documentation a little less outdated. Just wanted to submit a pull request just in case. You can make as many changes as you want.