Improve the prior shared memory setup requirements #222
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not all functions defined in this extension require the shared memory for data exchange. Properly highlight this requirement and also add an non-normative text in the function which does not depends on shared memory setup such as sbi_mpxy_get_shmem_size. Reported-by: Alvin Chang <[email protected]> Signed-off-by: Rahul Pathak <[email protected]>
|
I sent this patch over email too sometime back but for visibility and review raising the PR here |
atishp04
approved these changes
Oct 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not all functions defined in this extension require the shared memory for data exchange. Properly highlight this requirement and also add an non-normative text in the function which does not depends on shared memory setup such as
sbi_mpxy_get_shmem_size.