-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix issue 504, purecap clarifications #505
fix issue 504, purecap clarifications #505
Conversation
Co-authored-by: Jessica Clarke <[email protected]> Signed-off-by: Tariq Kurd <[email protected]>
Wrong email address?.. (also in the git author for that commit) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with minor fix and author adjusted. I can try to fix this.
Signed-off-by: Alexander Richardson <[email protected]>
I do use that email address but thought I'd configured it to use my work one hmmmm |
There aren't any in the repo, this is the only instance I could see... so you probably want to be careful when doing a squash+merge that it picks the right author and that S-o-b gets trimmed in the message. |
looking in |
Signed-off-by: Tariq Kurd [email protected]
|
That is fine although for this repo |
The cheri-levels table had incorrect footnotes
I've also clarified that trying to set the M-bit in ACPERM on a purecap machine given invalid permissions