Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix issue 504, purecap clarifications #505

Merged
merged 4 commits into from
Jan 14, 2025

Conversation

tariqkurd-repo
Copy link
Collaborator

The cheri-levels table had incorrect footnotes
I've also clarified that trying to set the M-bit in ACPERM on a purecap machine given invalid permissions

@tariqkurd-repo tariqkurd-repo changed the title fix issue 504 fix issue 504, purecap clarifications Jan 10, 2025
src/insns/acperm_32bit.adoc Outdated Show resolved Hide resolved
@tariqkurd-repo tariqkurd-repo requested a review from jrtc27 January 10, 2025 16:33
src/level-ext.adoc Outdated Show resolved Hide resolved
Co-authored-by: Jessica Clarke <[email protected]>
Signed-off-by: Tariq Kurd <[email protected]>
@jrtc27
Copy link
Collaborator

jrtc27 commented Jan 10, 2025

Signed-off-by: Tariq Kurd [email protected]

Wrong email address?.. (also in the git author for that commit)

src/level-ext.adoc Outdated Show resolved Hide resolved
Copy link
Collaborator

@arichardson arichardson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with minor fix and author adjusted. I can try to fix this.

Signed-off-by: Alexander Richardson <[email protected]>
@tariqkurd-repo
Copy link
Collaborator Author

Signed-off-by: Tariq Kurd [email protected]

Wrong email address?.. (also in the git author for that commit)

I do use that email address but thought I'd configured it to use my work one hmmmm
There'll be many commits from that one as a result....

@jrtc27
Copy link
Collaborator

jrtc27 commented Jan 10, 2025

Signed-off-by: Tariq Kurd [email protected]

Wrong email address?.. (also in the git author for that commit)

I do use that email address but thought I'd configured it to use my work one hmmmm There'll be many commits from that one as a result....

There aren't any in the repo, this is the only instance I could see... so you probably want to be careful when doing a squash+merge that it picks the right author and that S-o-b gets trimmed in the message.

@tariqkurd-repo
Copy link
Collaborator Author

looking in git log all seems to be correct so I'll merge

@tariqkurd-repo
Copy link
Collaborator Author

Signed-off-by: Tariq Kurd [email protected]
Signed-off-by: Alexander Richardson [email protected]
Co-authored-by: Jessica Clarke [email protected]
Co-authored-by: Alexander Richardson [email protected]

Alexander Richardson <[email protected]> is this expected @arichardson ?

@arichardson
Copy link
Collaborator

Signed-off-by: Tariq Kurd [email protected] Signed-off-by: Alexander Richardson [email protected] Co-authored-by: Jessica Clarke [email protected] Co-authored-by: Alexander Richardson [email protected]

Alexander Richardson <[email protected]> is this expected @arichardson ?

That is fine although for this repo [email protected] is probably better.

@tariqkurd-repo tariqkurd-repo merged commit e4f04b7 into riscv:main Jan 14, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants