fix: accurate gpa calculations

moved rounding the gpa to frontend instead of backend
rithask · May 16, 2024 · 3fa0136 · 3fa0136
1 parent 7940a9b
commit 3fa0136
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/backend/utils/helper.js b/backend/utils/helper.js
@@ -131,7 +131,7 @@ const calculateSgpa = (result, credits) => {
     sgpa += getGradePoint(course.grade) * course.credit
   })
   sgpa = (sgpa / credits)
-  sgpa = Math.round((sgpa + Number.EPSILON) * 100) / 100
+  // sgpa = Math.round((sgpa + Number.EPSILON) * 100) / 100
 
   return sgpa
 }
@@ -144,7 +144,7 @@ const calculateCgpa = (semesters) => {
     cgpa += sem.sgpa * sem.allotedCredits
   })
   cgpa = (cgpa / total_credits)
-  cgpa = Math.round((cgpa + Number.EPSILON) * 100) / 100
+  // cgpa = Math.round((cgpa + Number.EPSILON) * 100) / 100
 
   return cgpa
 }

diff --git a/frontend/src/components/ResultTable.jsx b/frontend/src/components/ResultTable.jsx
@@ -9,7 +9,7 @@ const ResultTable = ({ result, updateSemester }) => {
         <h1>{result.semester}</h1>
         {!result.completed && <button onClick={() => updateSemester(result.semester, result.lastExamDefId || result.examDefId)}>Update</button>}
       </div>
-      <p>SGPA: {result.sgpa}</p>
+      <p>SGPA: {result.sgpa.toFixed(2)}</p>
       <table>
         <thead>
           <tr>

diff --git a/frontend/src/components/Table.jsx b/frontend/src/components/Table.jsx
@@ -54,7 +54,7 @@ const Table = ({ data, updateSemester }) => {
             </tr>
             <tr>
               <td>CGPA</td>
-              <td style={{ color: personalDetails.cgpa >= 7.5 ? "green" : "red" }}>{personalDetails.cgpa}</td>
+              <td style={{ color: personalDetails.cgpa >= 7.5 ? "green" : "red" }}>{personalDetails.cgpa.toFixed(2)}</td>
             </tr>
           </tbody>
         </table>