Focus Management within Shadow DOM #1
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* disable snapshot for regular stories, remove s2 from title * add chromatic stories from missing components * fix lint * add more chromatic stories for missing components and remove s2 prefix * remove disable snapshot, update chromatic-fc * Some docs improvements --------- Co-authored-by: Devon Govett <[email protected]>
* S2 chromatic table * fix cardview chromatic stories
* Export pressScale and focusRing utilities from S2 * Also export StyleString type
* Rename SegmentedControl props to match selection APIs * fix chromatic stories * ts strict * Add AriaLabelingProps * Pass value and defaultValue to RadioGroup * fix merge conflicts
* add disclosure tests * lint/cleanup * Pass isExpanded to useDisclosure as well --------- Co-authored-by: Robert Snow <[email protected]> Co-authored-by: Devon Govett <[email protected]>
* fix macro import in codemod output * remove recast patch
* Updated @react-spectrum/picker translations to match latest English 'Select...' * Latest @react-spectrum/s2 translations, partially complete * remove .localizationManfiest as not needed for github * Updated translations from PR review
* fix codemod parsing files with macro * fix s2 imports being removed
* Add color components to monopackages * Remove beta tag from docs * Add color picker component cards to home pages * Add color components to tailwind starter * update yarn lock * remove old css parser * run docs-verdaccio * Revert "run docs-verdaccio" This reverts commit 5a15a3d. * fix heading level * fix safari doing weird things on mousedown of the cards * improve ColorSwatchPicker dark mode * fix centering
* Expand dependency version support in Icon Transformer * add test for icon builder to verdaccio build * fix the range for the builder since we're pre-release * fix yarn lock * update verdaccio script to handle packages which are in pre-release without a major version * update yarn lock * turn off verdaccio again * turn back on verdaccio * turn verdaccio back off * Fix parcel plugin version --------- Co-authored-by: Devon Govett <[email protected]>
* add @storybook/addon-a11y to s2 storybook * update yarn.lock * fix a11y issues in stories * add @storybook/addon-a11y to s2 storybook * update yarn.lock * fix a11y issues in stories --------- Co-authored-by: Daniel Lu <[email protected]>
…dobe#7161) * Add missing slot contexts to CardView and TableView * add forwardRef to Table sub components
…e#7141) * TypeScript plugin to add macro import attribute to auto imports * fix lockfile
* Update JSDocs and apis for release * typo
# Conflicts: # packages/@react-aria/focus/src/FocusScope.tsx
* Revert "chore: Update JSDocs and apis for release (adobe#7595)" This reverts commit 101d077. * Revert "fix: Tabs infinite loop (adobe#7487)" This reverts commit 8228e4e. * Revert "fix: Tabs from testing (adobe#7463)" This reverts commit 494e01c. * Revert "feat: Tabs collapse behaviour (adobe#7202)" This reverts commit cd4da2b. * add stuff back that we still want * update lock
…7145) * scaffolding and documenting tester api * fix strict mode * update utils for conformity and add intro * add instalation, setup, and update method types * update docs with examples and update types * remove some todos * forgot to remove a only * fix lint * fix lint again, for some reason local lint doesnt catch this one... * review comments * update select option methods to accept node, string, and index using a single unified option for simplicity * fix tests and more consistency refactors * updating copy per review * feat: Next batch of aria utils (Listbox, Tabs, Tree) (adobe#7505) * adding listbox test utils and clean up of other utils * check that util works in tests * add docs * test listbox util get options section scoping * tabs test utils * add tests for tab test utils * add docs for tabs testing * update jsdoc and adding version badge * pulling in tree utils from s2-treeview branch modified some of the utils for consistency, but otherwise kept most of it the same. Changes to be discussed * update docs and use the utils in the spectrum tests * making things more consistent * fix tests temporarily * fix keyboard navigation if row is disabled * review comments * small fixes from review * update testing pages to be more standalone as per review * add alpha badge * review comments
* feat: Support CSS transitions in RAC * jsdom * Fix interrupting * Update ActionBar and Tooltip * Update docs * Remove alpha badge from RAC * fix comments * review updates --------- Co-authored-by: Robert Snow <[email protected]>
…is pressed (adobe#7606) * Pass value directly to SearchField so that clear button works when clicked * fix test label * add props to TextFieldProps instead * review comments * fix Esc key handling so it doesnt clear the input field and clear selected keys * get rid of inputRef and fix color field types
…lly (adobe#7608) * ensure tags with and without icons are aligned vertically * edit existing story
* Fix dependencies * fix 16 and 17 tests * update lockfile
* fix: React inert prop compatibility * chore: lint * Check using `React.version` * Fix type * fix lint --------- Co-authored-by: GitHub <[email protected]> Co-authored-by: Robert Snow <[email protected]>
…us (adobe#7513) * fix(@react-aria/selection): don't mutate non-empty selection upon focus closes adobe#7512 * add some assertions --------- Co-authored-by: GitHub <[email protected]> Co-authored-by: Robert Snow <[email protected]> Co-authored-by: Reid Barber <[email protected]>
* Replace comma operator with semicolon for better readability Closes adobe#5820 * docs: Update Slider.mdx * fix other typo --------- Co-authored-by: Reid Barber <[email protected]>
…anage focus (adobe#7542) * working first pass * Update mouse and touch handlers as well * Always set a tabIndex on native buttons and inputs so Safari focuses them * lint * Update tests * Make grid selection announcement more resilient to focus order * Remove focus during virtual clicks adobe#5940 * Add test story for adobe#7480 * Add story for adobe#6512 * Make sure to cancel press if onClick's propagation is stopped For adobe#5833 * fix ts * Use focusWithoutScrolling when restoring focus
snowystinger
force-pushed
the
shadow-dom-enhancement-1-getRootNode
branch
from
80daa95 to
21b80bd
Compare
# Conflicts: # packages/@react-aria/focus/src/FocusScope.tsx # packages/@react-aria/interactions/src/usePress.ts # packages/@react-aria/interactions/test/usePress.test.js # packages/@react-spectrum/table/test/Table.test.js
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes adobe#1472
✅ Pull Request Checklist:
📝 Test Instructions:
🧢 Your Project: