Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Focus Management within Shadow DOM #1

Draft
wants to merge 944 commits into
base: shadow-dom-base-branch
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
944 commits
Select commit Hold shift + click to select a range
c353e15
Remove S2 prefix from docs storybook (#7089)
yihuiliao Sep 26, 2024
766a5f0
S2 chromatic table (#7098)
snowystinger Sep 26, 2024
72be76a
Export pressScale and focusRing utilities from S2 (#7078)
devongovett Sep 26, 2024
0b314ea
Rename SegmentedControl props to match selection APIs (#7097)
devongovett Sep 26, 2024
d57bd8d
fix+tests: fix Disclosure bugs and add tests (#7096)
reidbarber Sep 26, 2024
9a60dca
fix macro import in codemod output (#7112)
reidbarber Sep 27, 2024
71072b8
Latest translations (#7106)
rgeraghty Sep 27, 2024
e60fb42
Centralize S2 icon wrapper (#7113)
devongovett Sep 27, 2024
82f0c99
Rename Table -> TableView, skip some codemods for now (#7118)
devongovett Sep 30, 2024
daed8ca
fix: support parsing files with macros in codemod (#7114)
reidbarber Sep 30, 2024
948fcd2
Prepare color picker components for GA (#7122)
devongovett Sep 30, 2024
461b604
Publish
devongovett Sep 27, 2024
7b6fc10
Release notes for S2 v0.4.0 (#7099)
devongovett Oct 1, 2024
44fa2a5
September v3 Release Notes (#7101)
yihuiliao Oct 1, 2024
f489e00
add Accordion breaking changes to release notes (#7128)
reidbarber Oct 1, 2024
c01850b
Add versions to release notes, and starter kit links to color picker …
devongovett Oct 1, 2024
4818630
Rename Table -> TableView in S2 release notes (#7130)
devongovett Oct 1, 2024
920832d
Blog post: Accessible Color Descriptions for Improved Color Pickers (…
devongovett Oct 2, 2024
fc02d6e
remove unused svg
devongovett Oct 2, 2024
240c29b
Bump browserslist resolution to 4.24 (#7137)
devongovett Oct 2, 2024
25f304d
Fix Meter docs story so it renders with the proper width (#7140)
LFDanLu Oct 3, 2024
df6e3c0
Temporary fix for S2 storybook crash when showing code in dark mode (…
LFDanLu Oct 8, 2024
139a72d
Expand dependency version support in Icon Transformer (#7133)
snowystinger Oct 8, 2024
03cfde2
Publish
devongovett Oct 8, 2024
533a02f
Update yarn.lock
devongovett Oct 8, 2024
bebc976
add @storybook/addon-a11y to S2 storybook (#7068)
reidbarber Oct 9, 2024
454da05
Add missing slot contexts and forwardRefs to CardView and TableView (…
LFDanLu Oct 10, 2024
8a7cb15
TypeScript plugin to add macro import attribute to auto imports (#7141)
devongovett Oct 10, 2024
e9aa00a
fix tanstack router useHref example (#7148)
kveperedo Oct 10, 2024
0c28454
fix: [RAC] Checkbox applies data attributes to both the input and the…
syd03098 Oct 10, 2024
a45e2a5
fix(s2): ensure slider respects custom widths and correct the fillOff…
yihuiliao Oct 10, 2024
db60bab
feat: support label position side in meter (#7180)
yihuiliao Oct 11, 2024
c42990f
Fix usePress so it doesnt preventDefault when taps happen on non plai…
LFDanLu Oct 14, 2024
f0245fd
Publish
devongovett Oct 14, 2024
987f174
Update table resizer svg and bump tokens package (#7154)
LFDanLu Oct 15, 2024
e22e960
Add expanded boolean attribute to tailwind plugin (#7152)
neefrehman Oct 15, 2024
f77152e
fix: add Checkbox default slot to GridList and Table (#7188)
snowystinger Oct 15, 2024
f459c18
Fix NumberParser getSymbols rounding support (#7186)
snowystinger Oct 15, 2024
7a9c220
Decrease timeouts in test utils (#7102)
snowystinger Oct 15, 2024
ce87249
feat: Lint pr titles (#6770)
yihuiliao Oct 15, 2024
0d0e21b
Mask the contents of a scrolled row for a quiet table (#7193)
LFDanLu Oct 15, 2024
06cdad7
docs: add contributing Q & A section (#6951)
unional Oct 15, 2024
9152d83
fix: ensure `Dialog` has the `data-rac` attribute (#7189)
amitdahan Oct 15, 2024
e1b72a7
Set default value for type parameter in SelectProps (#7014)
kp047i Oct 16, 2024
27d8d85
Merge branch 'main' into shadow-dom-enhancement-1-getRootNode
snowystinger Oct 16, 2024
b958085
feat(s2): update accordion api to allow sibling elements in disclosur…
yihuiliao Oct 17, 2024
72a85cc
docs: Disclosure hook docs (#7178)
reidbarber Oct 18, 2024
69109f0
docs(RAC): add tailwind starter for Disclosure and DisclosureGroup (#…
reidbarber Oct 18, 2024
18835f7
docs: update accordion, disclosure, disclosure group docs (#7165)
yihuiliao Oct 18, 2024
0ddbe6f
chore: Update linting (#7201)
snowystinger Oct 18, 2024
b887497
fix: Support hidden="until-found" in DisclosureGroup (#7199)
reidbarber Oct 21, 2024
4f85a35
fix: Accordion/Disclosure release prep (#7216)
reidbarber Oct 21, 2024
a56a735
fix(examples): s2 dialog's weren't closing (#7219)
ktabors Oct 22, 2024
cbac9c0
chore: eslint speed up (#7222)
snowystinger Oct 23, 2024
68e3057
fix dialog codemod close function (#7233)
reidbarber Oct 23, 2024
09dc3c0
fix useButton href condition (#7239)
mehm8128 Oct 23, 2024
22e75e6
Merge branch 'main' into shadow-dom-enhancement-1-getRootNode
MahmoudElsayad Oct 23, 2024
51932a5
- Update the usages of `instanceof` to use `nodeType` instead.
MahmoudElsayad Oct 24, 2024
fb28ab3
fix: TS Strict aria C and D (#6761)
snowystinger Oct 24, 2024
37fbf02
support pending in RAC tailwind plugin (#7231)
reidbarber Oct 24, 2024
cd313a3
feat: Reusable tests (#7011)
snowystinger Oct 24, 2024
93c26d8
RAC: Fix tooltip stuck on screen when scrolling (#7227)
acr92 Oct 24, 2024
541dd5f
Update packages/@react-aria/interactions/src/useFocusVisible.ts
MahmoudElsayad Oct 25, 2024
4b35260
Merge branch 'main' into shadow-dom-enhancement-1-getRootNode
MahmoudElsayad Oct 25, 2024
3fa8c44
- Update the usages of `instanceof` to use `nodeType` instead.
MahmoudElsayad Oct 25, 2024
ab9f8db
- Lint.
MahmoudElsayad Oct 25, 2024
47be393
- Lint.
MahmoudElsayad Oct 25, 2024
e24ea2f
fix tailwind starter submenu story (#7251)
reidbarber Oct 28, 2024
6607108
fix: Accordion/Disclosure fixes from testing (#7218)
reidbarber Oct 28, 2024
4baa1b0
Make sure there arent dupe stories between Disclosure and Accordion (…
LFDanLu Oct 28, 2024
60a1842
docs: add new S2 components to example apps (#7244)
reidbarber Oct 29, 2024
f598966
Get rid of UNSTABLE prefix on tailwind docs build (#7275)
LFDanLu Oct 29, 2024
b01fbf2
fix(tailwind): correct disabled tag styles (#7247)
steveoh Oct 29, 2024
e92ccd7
chore: add accordion to monopackage (#7285)
yihuiliao Oct 29, 2024
46ab0c8
docs: update accordion and disclosure group docs (#7273)
yihuiliao Oct 29, 2024
07431f4
refactor: Use calc to implement S2 touch scale (#7281)
devongovett Oct 30, 2024
2f7f10d
docs: update contribution guide (#7253)
yihuiliao Oct 30, 2024
09f74f4
docs: Add docs for style macro color and typography values, and focus…
devongovett Oct 30, 2024
dcc0752
feat: Section-level selection groups in Menu (#7254)
devongovett Oct 30, 2024
54cfe24
- Update `getDeepActiveElement` to accept an optional document or sha…
MahmoudElsayad Oct 31, 2024
e918e38
Merge branch 'main' into shadow-dom-enhancement-1-getRootNode
MahmoudElsayad Oct 31, 2024
96b5eec
chore: add accordion to v3 example apps (#7296)
yihuiliao Oct 31, 2024
17daa02
fix: add `"use strict";` to style macro cjs output (#7271)
reidbarber Oct 31, 2024
e37ad74
fix: miscellaneous s2 bug fixes (#7295)
yihuiliao Oct 31, 2024
95a6b64
- Add extra unit test for `getDeepActiveElement`.
MahmoudElsayad Nov 1, 2024
c830aab
- Update `getDeepActiveElement` to always rely on `getRootNode`.
MahmoudElsayad Nov 1, 2024
319617f
- Update `getDeepActiveElement` to always rely on `getRootNode`.
MahmoudElsayad Nov 1, 2024
3e1730e
Merge branch 'main' into shadow-dom-enhancement-1-getRootNode
MahmoudElsayad Nov 1, 2024
a9e28af
chore: Add rel canonical to documentation pages (#7298)
ross-pfahler Nov 1, 2024
0d0af54
Merge branch 'main' into shadow-dom-enhancement-1-getRootNode
snowystinger Nov 1, 2024
f554c29
fix: v3 Accordion borders (#7284)
reidbarber Nov 1, 2024
f256f0e
fix: Remove iOS HiddenSelect workaround (#7200)
snowystinger Nov 1, 2024
14067de
fix: DatePicker with defaultValue persists time zone (#7069)
boutahlilsoufiane Nov 1, 2024
b390efb
fix: S2 Disclosure button width (#7293)
reidbarber Nov 1, 2024
12920fc
build: Update S2 storybook and example apps to optimize CSS bundling …
devongovett Nov 1, 2024
5ed0606
[fix] make us resilient to time changes in datepicker tests (#7311)
snowystinger Nov 4, 2024
2be0fee
docs: fix disclosure group anatomy svg from clipping on mobile (#7323)
yihuiliao Nov 5, 2024
426bff1
revert: radio animation (#7316)
yihuiliao Nov 5, 2024
84e0437
fix: ensure text truncates in s2 toggle button (#7322)
yihuiliao Nov 6, 2024
55bc401
chore: more s2 bug fixes (#7324)
yihuiliao Nov 6, 2024
09f5e8a
chore: update token colors in meter, illustrated message (#7205)
yihuiliao Nov 6, 2024
c703323
feat: Add ToggleButtonGroup component to RAC and S2 (#7264)
devongovett Nov 6, 2024
09ccc53
fix: v3 accordion focus ring gap + useDisclosure disabled docs exampl…
reidbarber Nov 6, 2024
694fc85
chore: Update S2 icons (#7329)
devongovett Nov 7, 2024
3f67667
chore: fix chromatic stories + add ToggleButtonGroup and ActionButton…
yihuiliao Nov 9, 2024
791f9c5
Fix ToggleProps validate function type (#7347)
joshuajaco Nov 11, 2024
f08b17d
feat: add support for Devanagari & Bengali decimal numbering systems …
Rocss Nov 12, 2024
7e834a9
add `box-sizing: content-box` accordion chevron (#7354)
reidbarber Nov 12, 2024
7aa6265
remove z-index from SegmentedControl text (#7355)
reidbarber Nov 12, 2024
563501a
Merge branch 'main' into shadow-dom-enhancement-1-getRootNode
snowystinger Nov 13, 2024
c2c7fb0
fix: update restrictValues in useSliderState (#7338)
Danji-ya Nov 13, 2024
3949762
Allowing BC era timestamps in fromAbsolute (#6541) (#6542)
KimPeeters Nov 13, 2024
262cc75
fix: checkbox validation reset not working (#7268)
nwidynski Nov 13, 2024
4f23f2a
chore: update s2 tokens (#7371)
snowystinger Nov 15, 2024
a5d52e8
Latest translations (#7351)
rgeraghty Nov 15, 2024
e388eea
docs: update codesandbox templates in useDatePicker and useDateRangeP…
yihuiliao Nov 15, 2024
3a658e7
chore: add isJustified to segmented control in s2 example apps (#7362)
yihuiliao Nov 15, 2024
a98da55
fix: prefix S1 style macro class names (#7365)
reidbarber Nov 15, 2024
3f44370
fix typo on progress bar docs (#7373)
mehm8128 Nov 16, 2024
d8161f6
chore: support react 19 prerelease (#7383)
snowystinger Nov 18, 2024
dc58cd6
fix: Accordion release audit (#7369)
reidbarber Nov 18, 2024
22fb5ba
chore: Update Parcel to v2.13.0 (#7359)
devongovett Nov 18, 2024
a006743
feat: Support custom dialog layouts in S2 (#7352)
devongovett Nov 18, 2024
6d6e530
chore: test for time conversion edge case and fuzzy test numeral syst…
snowystinger Nov 18, 2024
1908374
feat: Allow arbitrary pixel sizes in S2 style macro (#7385)
devongovett Nov 18, 2024
9b249e0
chore: Ts strict remaining (#7368)
snowystinger Nov 18, 2024
0574faf
fix verdaccio docs build (#7389)
reidbarber Nov 18, 2024
0ab0544
fix: Accordion release fixes (#7391)
reidbarber Nov 19, 2024
bd2ca0b
fix: Toast examples in iframes (#7390)
snowystinger Nov 19, 2024
b3a4d6c
fix: add optional property types (#6872)
alecmev Nov 19, 2024
f2d996d
docs: add APG grid link to useTagGroup doc (#7367)
mehm8128 Nov 19, 2024
f33288c
fix: Revert displaying popovers as modals on mobile for now (#7392)
devongovett Nov 19, 2024
52e167d
chore: Revert exactOptionalPropertyTypes id support (#7400)
snowystinger Nov 19, 2024
8217bd4
chore: Update S2 Dialog codemods (#7388)
devongovett Nov 20, 2024
65e3a52
Improve error message for missing Provider error (#7404)
LFDanLu Nov 20, 2024
16153ed
chore: Add ActionButtonGroup and ToggleButtonGroup to example apps an…
devongovett Nov 20, 2024
62718d4
Document RAC Dialog close button slot (#7405)
devongovett Nov 20, 2024
baa330f
feat: Add RAC example of Menu nested in popover dialog (#7402)
devongovett Nov 20, 2024
52bf91b
feat: Add codemod for ActionGroup (#7396)
devongovett Nov 20, 2024
9170093
fix(#7399): DatePicker.test fails with daylight savings change (#7401)
majornista Nov 20, 2024
2e1dd22
fix: Handle more BC date cases (#7410)
devongovett Nov 20, 2024
c6bd2cb
chore: Update dialog examples to be more generic (#7415)
devongovett Nov 21, 2024
a530335
chore: revert export provider context (#7416)
snowystinger Nov 21, 2024
17358f7
Publish
devongovett Nov 21, 2024
5107e17
chore: Update "version added" for remaining RSP components (#7417)
LFDanLu Nov 21, 2024
d142c4e
docs: November 2024 v3 Release Notes (#7414)
reidbarber Nov 21, 2024
bf8fcf5
docs: S2 release notes (#7406)
LFDanLu Nov 21, 2024
881c947
Merge branch 'main' of github.com:adobe/react-spectrum
devongovett Nov 21, 2024
71f0ef2
Update yarn.lock
devongovett Nov 21, 2024
56e5757
docs: Improve Menu selection group story (#7419)
devongovett Nov 21, 2024
8b3c35e
fix release notes typo (#7422)
reidbarber Nov 21, 2024
92e55da
Remove pre-release badges from disclosure docs
devongovett Nov 21, 2024
ab9fd5c
docs: Add note about RAC Section deprecation to release notes (#7424)
devongovett Nov 21, 2024
b54c0d4
fix: [BUG] - Autocomplete - Text selection with Shift + Home/End isn'…
majornista Nov 26, 2024
10a43de
chore: Improve React Fast Refresh in storybook (#7435)
devongovett Nov 26, 2024
c266dc2
fix: Combobox docs example (#7439)
snowystinger Nov 27, 2024
f14ca9b
chore: throw when macros are called not as a macro (#7441)
snowystinger Nov 27, 2024
2d45210
fix: prevent disabled Tag from being removed with keyboard nav (#7394)
minzzang144 Nov 27, 2024
b0f1569
refactor: Remove custom hit testing in usePress (#7427)
devongovett Nov 27, 2024
99d073a
fix: tabbing past contenteditable=false in containing focusscope (#7340)
nwidynski Dec 2, 2024
cd4da2b
feat: Tabs collapse behaviour (#7202)
snowystinger Dec 2, 2024
e94e364
Add test and fix for #5692 (#7455)
richardbann Dec 2, 2024
e14088a
add box-sizing: content-box Accordion chevron (#7456)
reidbarber Dec 3, 2024
5aeb024
Merge branch 'main' into shadow-dom-enhancement-1-getRootNode
snowystinger Dec 3, 2024
03c23c4
refactor usePress to still have global listeners for cleanup across b…
snowystinger Dec 3, 2024
cf3f567
fix lint and test
snowystinger Dec 4, 2024
5757c3a
fix: S2 examples Popover and add CustomDialog (#7459)
ktabors Dec 4, 2024
494e01c
fix: Tabs from testing (#7463)
snowystinger Dec 4, 2024
7eae25e
passing autoComplete prop from Select to underlying child component (…
nabanitabania Dec 4, 2024
369e1e7
don't use hooks conditionally in docs (#7473)
nathanpower Dec 5, 2024
b4ed1d4
fix: chromatic s2 stories (#7476)
snowystinger Dec 5, 2024
f90799b
feat: Add Autocomplete wrapper for Menu and ListBox (#7181)
LFDanLu Dec 6, 2024
b37f279
Publish
devongovett Dec 6, 2024
a89b7c8
fix: Remove onTouchEnd handler in iOS usePreventScroll (#7479)
devongovett Dec 7, 2024
8228e4e
fix: Tabs infinite loop (#7487)
snowystinger Dec 7, 2024
993de98
fix(scrollIntoView): respect scroll padding (#7484)
jeffijoe Dec 9, 2024
19bc0b8
fix gradient illustration path copied by in docs (#7503)
reidbarber Dec 10, 2024
64348e4
Merge branch 'main' into shadow-dom-enhancement-1-getRootNode
snowystinger Dec 11, 2024
ec25ca4
fix: Nightlies (#7486)
snowystinger Dec 11, 2024
b75aaa5
fix: build website (#7509)
snowystinger Dec 11, 2024
326f481
fix: remove min/max limits for all segments in `parseDuration` (#7064)
limkhl Dec 12, 2024
fc82be0
restore remaining document level listeners
snowystinger Dec 12, 2024
b62d83f
fix tests
snowystinger Dec 13, 2024
366565c
fix lint
snowystinger Dec 13, 2024
f93cb20
fix: make empty SlotsProvider context stable (#7485)
mdwyer6 Dec 16, 2024
b82d0da
fix: S2 menu press scaling (#7492)
devongovett Dec 16, 2024
a71fbed
feat: Add staticColor="auto" variant (#7464)
devongovett Dec 16, 2024
a97b874
fix MenuSection in RAC Tailwind starter (#7508)
reidbarber Dec 16, 2024
fee532d
fix: prod docs (#7523)
devongovett Dec 16, 2024
edc9892
simplify
snowystinger Dec 16, 2024
9b08f75
Update packages/@react-aria/focus/src/FocusScope.tsx
snowystinger Dec 16, 2024
39543de
Merge branch 'main' into shadow-dom-enhancement-1-getRootNode
snowystinger Dec 16, 2024
4c4e006
fix autofocus
snowystinger Dec 16, 2024
c8bcc04
fix(s2): Remove maxWidth from InlineAlert (#7533)
devongovett Dec 17, 2024
e624164
fix(s2): Display checkmark on selected menu items that are links (#7532)
devongovett Dec 17, 2024
adc21f8
fix(form): skip native validation on disabled form elements (#7531)
reidbarber Dec 18, 2024
adae13c
fix(S2): ContextualHelp in Field wrapping to new line (#7491)
reidbarber Dec 18, 2024
bbdb342
Merge branch 'main' into shadow-dom-enhancement-1-getRootNode
snowystinger Dec 18, 2024
4b97149
fix(S2): clear isRequired context for CheckboxGroup in Form (#7522)
reidbarber Dec 18, 2024
96b9166
minor test updates to preserve test intent
LFDanLu Dec 18, 2024
ea24e97
feat: Add S2 ActionBar component (#7446)
devongovett Dec 19, 2024
0ab792f
feat: add gradient variants to Button (#7514)
jluyau Dec 19, 2024
87b3542
review comments
snowystinger Dec 19, 2024
50c7ada
fix: disable form submission for isPending (#7498)
snowystinger Dec 19, 2024
650bf4a
fix esm test
snowystinger Dec 23, 2024
1660aad
fix lint
snowystinger Dec 23, 2024
4dd0993
Fix: broken links in docs and renaming Twitter to X (#7530)
ktabors Dec 23, 2024
835f0aa
feat: RAC Autocomplete audit for release (#7475)
LFDanLu Jan 6, 2025
3e352bf
Update gradient buttons so that outline and fill are the same (#7575)
LFDanLu Jan 7, 2025
3f8b6b8
docs: add rss feed to release notes and blog posts (#7534)
yihuiliao Jan 7, 2025
9d30e15
fix: Fix Talkback focus cursor movement when inside Dialogs (#7478)
LFDanLu Jan 7, 2025
d382c59
fix: explicitly set content-box on unavailable icon in Menu (#7572)
yihuiliao Jan 8, 2025
e7053dd
Use absolute path resolution for empty.js (#7568)
ohansFavour Jan 8, 2025
d969d73
feat: S2 Menu design updates (#7580)
devongovett Jan 8, 2025
c246c2e
fix: Autocomplete event leak and erroneous item focus after backspaci…
LFDanLu Jan 9, 2025
af56de0
fix: Don't close popovers on scroll (#7541)
jabrks Jan 9, 2025
d87cc44
docs: Add initial Autocomplete docs (#7581)
devongovett Jan 9, 2025
82a4de5
feat(Calendar): Add `firstDayOfWeek` prop (#7363)
reidbarber Jan 9, 2025
6e6ae21
fix(s2): Make gradient buttons have an animated transition (#7585)
devongovett Jan 9, 2025
ee685cc
chore: Remaining Autocomplete alpha release checklist audit items (#7…
LFDanLu Jan 9, 2025
7189386
feat: add TableView codemods (#7117)
reidbarber Jan 9, 2025
e4497fd
fix(s2): Improve high contrast mode in CloseButton (#7592)
devongovett Jan 10, 2025
73bbc40
remove internal contexts from RAC Calendar (#7593)
reidbarber Jan 10, 2025
101d077
chore: Update JSDocs and apis for release (#7595)
LFDanLu Jan 10, 2025
d90cc98
Merge branch 'main' into shadow-dom-enhancement-1-getRootNode
snowystinger Jan 13, 2025
191df02
chore: Revert tabs collapse (#7599)
LFDanLu Jan 13, 2025
32a9a54
feat: Initial aria test util docs and listbox/tabs/tree utils (#7145)
LFDanLu Jan 13, 2025
1b425ca
feat: Support CSS transitions in RAC (#7488)
devongovett Jan 14, 2025
e29b059
fix(s2): Improve ActionBar transition when scrollbars are visible (#7…
devongovett Jan 14, 2025
1d9e615
fix: Properly clear Autocomplete wrapped SearchField when "x" button …
LFDanLu Jan 14, 2025
a9d4fef
fix(TagGroup): ensure Tags with and without icons are aligned vertica…
reidbarber Jan 14, 2025
c53ab48
fix: dependencies and peer dependencies (#7610)
snowystinger Jan 15, 2025
1b4236c
Publish
devongovett Jan 15, 2025
80f8a2b
chore: Update test util doc examples so they don't error out (#7612)
LFDanLu Jan 15, 2025
09e7f44
Merge branch 'main' of github.com:adobe/react-spectrum
devongovett Jan 15, 2025
75b74b1
docs: January 2025 release notes (#7597)
ktabors Jan 15, 2025
78683ee
add placement prop to ToastContainer (#7609)
reidbarber Jan 15, 2025
55dc352
fix: React inert prop compatibility (#7519)
chirokas Jan 15, 2025
6806410
fix(@react-aria/selection): don't mutate non-empty selection upon foc…
alirezamirian Jan 15, 2025
ce54e26
update toast placement options (#7615)
reidbarber Jan 15, 2025
c43a15e
Merge branch 'main' into shadow-dom-enhancement-1-getRootNode
snowystinger Jan 16, 2025
1286a65
fix(s2): Remove `all: revert-layer` to avoid Safari bugs (#7598)
devongovett Jan 16, 2025
0d962db
Merge branch 'main' into shadow-dom-enhancement-1-getRootNode
snowystinger Jan 16, 2025
9bf04b1
check in speed tests
snowystinger Jan 16, 2025
21b80bd
fix lint
snowystinger Jan 16, 2025
2b563a6
Fix broken link in new `Autocomplete` docs (#7618)
amitdahan Jan 16, 2025
1547e25
docs: fix typo in Slider (#7621)
artola Jan 16, 2025
df3f1ea
fix: Remove extra class from style macro (#7623)
devongovett Jan 16, 2025
cdba748
refactor: No longer preventDefault in usePress and allow browser to m…
devongovett Jan 17, 2025
5bf5bb7
Merge branch 'main' into shadow-dom-enhancement-1-getRootNode
snowystinger Jan 20, 2025
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
The diff you're trying to view is too large. We only load the first 3000 changed files.
12 changes: 12 additions & 0 deletions .chromatic-fc/.parcelrc
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
{
"extends": "@parcel/config-storybook",
"resolvers": ["@parcel/resolver-glob", "..."],
"transformers": {
"illustration:*.svg": ["@react-spectrum/parcel-transformer-s2-icon"],
"packages/@react-spectrum/s2/s2wf-icons/**/*.svg": ["@react-spectrum/parcel-transformer-s2-icon"],
"packages/*/*/intl/*.json": ["parcel-transformer-intl"],
// Disable PostCSS from running over style macro output
"packages/@react-spectrum/s2/**/*.css": ["@parcel/transformer-css"],
"packages/@react-spectrum/s2/**/*.svg": ["@parcel/transformer-svg-react"]
}
}
3 changes: 3 additions & 0 deletions .chromatic-fc/constants.js
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,9 @@ for (let key in themes) {
};
}

export let S2ColorThemes = ['light', 'dark'];
export let S2Backgrounds = ['base', 'layer-1', 'layer-2'];

// Based on https://adobe.sharepoint.com/sites/global/SitePages/Languages%20Supported.aspx
export let locales = [
{label: 'Auto', value: ''},
Expand Down
96 changes: 63 additions & 33 deletions .chromatic-fc/custom-addons/chromatic/index.js
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
import {expressThemes, locales, scales, themes} from '../../constants';
import {makeDecorator} from '@storybook/addons';
import {expressThemes, locales, S2ColorThemes, scales, themes} from '../../constants';
import {makeDecorator} from '@storybook/preview-api';
import {Provider, View} from '@adobe/react-spectrum';
import {Provider as S2Provider} from '@react-spectrum/s2';
import React, {useEffect} from 'react';
import './disableAnimations.css';

Expand All @@ -15,8 +16,7 @@ export const withChromaticProvider = makeDecorator({
} else {
selectedLocales = options.locales ? locales.map(l => l.value).slice(1) : ['en-US'];
}
let colorSchemes = options.express ? [] : (options.colorSchemes || ['light']);
let scalesToRender = options.scales || ['medium'];

let height;
let minHeight;
if(isNaN(options.height)) {
Expand All @@ -25,40 +25,70 @@ export const withChromaticProvider = makeDecorator({
height = options.height;
}

let expressTheme = colorSchemes.length === 1 ? expressThemes[colorSchemes[0]] : expressThemes.light;
let expressColorScheme = colorSchemes.length === 1 ? colorSchemes[0].replace(/est$/, '') : 'light';
let expressScale = scalesToRender.length === 1 ? scalesToRender[0] : 'medium';
let expressLocale = selectedLocales.length === 1 ? selectedLocales[0] : 'en-US';
if (context.title.includes('S2/')) {
return <RenderS2 getStory={getStory} context={context} options={options} selectedLocales={selectedLocales} height={height} minHeight={minHeight} />
} else {
return <RenderV3 getStory={getStory} context={context} options={options} selectedLocales={selectedLocales} height={height} minHeight={minHeight} />
}
}
});

function RenderS2({getStory, context, options, selectedLocales, height, minHeight}) {
let colorSchemes = options.colorSchemes || S2ColorThemes;

// do not add a top level provider, each provider variant needs to be independent so that we don't have RTL/LTR styles that interfere with each other
return (
<DisableAnimations disableAnimations={options.disableAnimations}>
<div style={{display: 'flex', flexDirection: 'column', height, minHeight}}>
{colorSchemes.map(colorScheme =>
scalesToRender.map(scale =>
(colorScheme === 'light' ? selectedLocales : ['en-US']).map(locale =>
<Provider key={`${colorScheme}_${scale}_${locale}`} theme={themes[colorScheme]} colorScheme={colorScheme.replace(/est$/, '')} scale={scale} locale={locale} typekitId="pbi5ojv">
<View margin="size-100">
<h1 style={{margin: 0, padding: 0}}>{`${colorScheme}, ${scale}, ${locale}`}</h1>
{getStory(context)}
</View>
</Provider>
)
)
)}
{options.express !== false &&
<Provider key="express" theme={expressTheme} colorScheme={expressColorScheme} scale={expressScale} locale={expressLocale} typekitId="pbi5ojv">
return (
<DisableAnimations disableAnimations={options.disableAnimations}>
<div style={{display: 'flex', flexDirection: 'column', height, minHeight, width: '90vw'}}>
{colorSchemes.map(colorScheme =>
(colorScheme === 'light' ? selectedLocales : ['en-US']).map(locale =>
<S2Provider key={`${colorScheme}_${locale}`} colorScheme={colorScheme} background="base" locale={locale}>
<div style={{margin: '8px'}}>
<h1 style={{margin: 0, padding: 0, color: colorScheme === 'dark' ? 'white' : 'black'}}>{`${colorScheme}, base, ${locale}`}</h1>
{getStory(context)}
</div>
</S2Provider>
)
)}
</div>
</DisableAnimations>
)
}

function RenderV3({getStory, context, options, selectedLocales, height, minHeight}) {
let colorSchemes = options.express ? [] : (options.colorSchemes || ['light']);
let scalesToRender = options.scales || ['medium'];
let expressTheme = colorSchemes.length === 1 ? expressThemes[colorSchemes[0]] : expressThemes.light;
let expressColorScheme = colorSchemes.length === 1 ? colorSchemes[0].replace(/est$/, '') : 'light';
let expressScale = scalesToRender.length === 1 ? scalesToRender[0] : 'medium';
let expressLocale = selectedLocales.length === 1 ? selectedLocales[0] : 'en-US';

return (
<DisableAnimations disableAnimations={options.disableAnimations}>
<div style={{display: 'flex', flexDirection: 'column', height, minHeight}}>
{colorSchemes.map(colorScheme =>
scalesToRender.map(scale =>
(colorScheme === 'light' ? selectedLocales : ['en-US']).map(locale =>
<Provider key={`${colorScheme}_${scale}_${locale}`} theme={themes[colorScheme]} colorScheme={colorScheme.replace(/est$/, '')} scale={scale} locale={locale} typekitId="pbi5ojv">
<View margin="size-100">
<h1 style={{margin: 0, padding: 0}}>express, {expressColorScheme}, {expressScale}, {expressLocale}</h1>
<h1 style={{margin: 0, padding: 0}}>{`${colorScheme}, ${scale}, ${locale}`}</h1>
{getStory(context)}
</View>
</Provider>
}
</div>
</DisableAnimations>
)
}
});
)
)
)}
{options.express !== false &&
<Provider key="express" theme={expressTheme} colorScheme={expressColorScheme} scale={expressScale} locale={expressLocale} typekitId="pbi5ojv">
<View margin="size-100">
<h1 style={{margin: 0, padding: 0}}>express, {expressColorScheme}, {expressScale}, {expressLocale}</h1>
{getStory(context)}
</View>
</Provider>
}
</div>
</DisableAnimations>
)
}

function DisableAnimations({children, disableAnimations}) {
useEffect(() => {
Expand Down
10 changes: 7 additions & 3 deletions .chromatic-fc/main.js
Original file line number Diff line number Diff line change
@@ -1,9 +1,13 @@

module.exports = {
core: {
builder: "storybook-builder-parcel",
framework: {
name: "storybook-react-parcel",
options: {},
},
stories: ['../packages/**/chromatic/**/*.chromatic-fc.{js,jsx,ts,tsx}'],
stories: [
'../packages/**/chromatic-fc/**/*.stories.{js,jsx,ts,tsx}',
'../packages/@react-spectrum/s2/chromatic/*.stories.@(js|jsx|mjs|ts|tsx)'
],
addons: process.env.NODE_ENV === 'production' ? [] : [
'@storybook/addon-actions',
'@storybook/addon-a11y'
Expand Down
8 changes: 5 additions & 3 deletions .chromatic-fc/manager.js
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
import addons from '@storybook/addons';
import {addons} from '@storybook/manager-api';

addons.setConfig({
showRoots: false,
enableShortcuts: false
enableShortcuts: false,
sidebar: {
showRoots: false,
}
});
6 changes: 6 additions & 0 deletions .chromatic-fc/preview-head.html
Original file line number Diff line number Diff line change
Expand Up @@ -134,6 +134,12 @@
<link rel="preload" href="https://use.typekit.net/af/838a89/00000000000000007735dab9/30/m?features=ALL&v=4&chunks=511&order=0" as="font" crossorigin="anonymous" />
<link rel="preload" href="https://use.typekit.net/af/758ab2/00000000000000007735dabe/30/m?features=ALL&v=4&chunks=511&order=0" as="font" crossorigin="anonymous" />

<!--
Load S2 adobe clean VF
-->
<link rel="preload" href="https://use.typekit.net/af/5e77d8/00000000000000007754d3a5/30/l?primer=f592e0a4b9356877842506ce344308576437e4f677d7c9b78ca2162e6cad991a&fvd=n1&v=3" as="font" crossorigin="anonymous" />
<link rel="stylesheet" href="https://use.typekit.net/yuq6kxz.css">

<!--
This web project loads adobe clean, adobe clean serif, myriad-arabic, myriad-hebrew, adobe-clean-han-japanese,
adobe-clean-han-korean, adobe-clean-han-simplified-c, and adobe-clean-han-traditional.
Expand Down
10 changes: 5 additions & 5 deletions .chromatic-fc/preview.js
Original file line number Diff line number Diff line change
Expand Up @@ -7,15 +7,15 @@ import {withChromaticProvider} from './custom-addons/chromatic';
// decorator order matters, the last one will be the outer most

configureActions({
depth: 10
depth: 2
});

export const parameters = {
options: {
storySort: (a, b) =>
a[1].kind === b[1].kind
? 0
: a[1].id.localeCompare(b[1].id, undefined, {numeric: true})
storySort: {
method: 'alphabetical',
order: ['*', 'S2']
}
},
a11y: {},
layout: 'fullscreen',
Expand Down
12 changes: 12 additions & 0 deletions .chromatic/.parcelrc
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
{
"extends": "@parcel/config-storybook",
"resolvers": ["@parcel/resolver-glob", "..."],
"transformers": {
"illustration:*.svg": ["@react-spectrum/parcel-transformer-s2-icon"],
"packages/@react-spectrum/s2/s2wf-icons/**/*.svg": ["@react-spectrum/parcel-transformer-s2-icon"],
"packages/*/*/intl/*.json": ["parcel-transformer-intl"],
// Disable PostCSS from running over style macro output
"packages/@react-spectrum/s2/**/*.css": ["@parcel/transformer-css"],
"packages/@react-spectrum/s2/**/*.svg": ["@parcel/transformer-svg-react"]
}
}
2 changes: 2 additions & 0 deletions .chromatic/constants.js
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,8 @@ for (let key in themes) {
};
}

export let S2ColorThemes = ['light', 'dark'];

// Based on https://adobe.sharepoint.com/sites/global/SitePages/Languages%20Supported.aspx
export let locales = [
{label: 'Auto', value: ''},
Expand Down
110 changes: 74 additions & 36 deletions .chromatic/custom-addons/chromatic/index.js
Original file line number Diff line number Diff line change
@@ -1,7 +1,10 @@
import {expressThemes, locales, scales, themes} from '../../constants';
import {makeDecorator} from '@storybook/addons';
import {expressThemes, locales, S2Backgrounds, S2ColorThemes, scales, themes} from '../../constants';
import {makeDecorator} from '@storybook/preview-api';
import {Provider, View} from '@adobe/react-spectrum';
import {Provider as S2Provider} from '@react-spectrum/s2';
import React, {useEffect} from 'react';
// TODO: can't seem to use the style macro here...
// import {style} from '../../../packages/@react-spectrum/s2/style/spectrum-theme' with {type: 'macro'};
import './disableAnimations.css';

export const withChromaticProvider = makeDecorator({
Expand All @@ -15,8 +18,7 @@ export const withChromaticProvider = makeDecorator({
} else {
selectedLocales = options.locales ? locales.map(l => l.value).slice(1) : ['en-US', 'ar-AE'];
}
let colorSchemes = options.express ? [] : (options.colorSchemes || Object.keys(themes));
let scalesToRender = options.scales || Object.keys(scales);

let height;
let minHeight;
if(isNaN(options.height)) {
Expand All @@ -25,41 +27,77 @@ export const withChromaticProvider = makeDecorator({
height = options.height;
}

let expressTheme = colorSchemes.length === 1 ? expressThemes[colorSchemes[0]] : expressThemes.light;
let expressColorScheme = colorSchemes.length === 1 ? colorSchemes[0].replace(/est$/, '') : 'light';
let expressScale = scalesToRender.length === 1 ? scalesToRender[0] : 'medium';
let expressLocale = selectedLocales.length === 1 ? selectedLocales[0] : 'en-US';

// do not add a top level provider, each provider variant needs to be independent so that we don't have RTL/LTR styles that interfere with each other
return (
<DisableAnimations disableAnimations={options.disableAnimations}>
<div style={{display: 'flex', flexDirection: 'column', height, minHeight}}>
{colorSchemes.map(colorScheme =>
scalesToRender.map(scale =>
(colorScheme === 'light' ? selectedLocales : ['en-US']).map(locale =>
<Provider key={`${colorScheme}_${scale}_${locale}`} theme={themes[colorScheme]} colorScheme={colorScheme.replace(/est$/, '')} scale={scale} locale={locale} typekitId="pbi5ojv">
<View margin="size-100">
<h1 style={{margin: 0, padding: 0}}>{`${colorScheme}, ${scale}, ${locale}`}</h1>
{getStory(context)}
</View>
</Provider>
)
)
)}
{options.express !== false &&
<Provider key="express" theme={expressTheme} colorScheme={expressColorScheme} scale={expressScale} locale={expressLocale} typekitId="pbi5ojv">
<View margin="size-100">
<h1 style={{margin: 0, padding: 0}}>express, {expressColorScheme}, {expressScale}, {expressLocale}</h1>
{getStory(context)}
</View>
</Provider>
}
</div>
</DisableAnimations>
)
if (context.title.includes('S2')) {
return <RenderS2 getStory={getStory} context={context} options={options} selectedLocales={selectedLocales} height={height} minHeight={minHeight} />
} else {
return <RenderV3 getStory={getStory} context={context} options={options} selectedLocales={selectedLocales} height={height} minHeight={minHeight} />
}
}
});

function RenderS2({getStory, context, options, selectedLocales, height, minHeight}) {
let colorSchemes = options.colorSchemes || S2ColorThemes;
let backgrounds = options.backgrounds || ['base'];

// TODO: there is perhaps some things that can still be shared between the two renders but figured it be easiest to just split them out for the most part
return (
<DisableAnimations disableAnimations={options.disableAnimations}>
<div style={{display: 'flex', flexDirection: 'column', height, minHeight, width: '90vw'}}>
{colorSchemes.map(colorScheme =>
backgrounds.map(background =>
(colorScheme === 'light' || context.title.includes('RTL') ? selectedLocales : ['en-US']).map(locale =>
<S2Provider key={`${colorScheme}_${background}_${locale}`} background={background} colorScheme={colorScheme} locale={locale}>
<div style={{margin: '8px'}}>
<h1 style={{margin: 0, padding: 0, color: colorScheme === 'dark' ? 'white' : 'black'}}>{`${colorScheme}, ${background}, ${locale}`}</h1>
{getStory(context)}
</div>
</S2Provider>
)
)
)}
</div>
</DisableAnimations>
)
}

function RenderV3({getStory, context, options, selectedLocales, height, minHeight}) {
let colorSchemes = options.express ? [] : (options.colorSchemes || Object.keys(themes));
let scalesToRender = options.scales || Object.keys(scales);

let expressTheme = colorSchemes.length === 1 ? expressThemes[colorSchemes[0]] : expressThemes.light;
let expressColorScheme = colorSchemes.length === 1 ? colorSchemes[0].replace(/est$/, '') : 'light';
let expressScale = scalesToRender.length === 1 ? scalesToRender[0] : 'medium';
let expressLocale = selectedLocales.length === 1 ? selectedLocales[0] : 'en-US';

// do not add a top level provider, each provider variant needs to be independent so that we don't have RTL/LTR styles that interfere with each other
return (
<DisableAnimations disableAnimations={options.disableAnimations}>
<div style={{display: 'flex', flexDirection: 'column', height, minHeight}}>
{colorSchemes.map(colorScheme =>
scalesToRender.map(scale =>
(colorScheme === 'light' ? selectedLocales : ['en-US']).map(locale =>
<Provider key={`${colorScheme}_${scale}_${locale}`} theme={themes[colorScheme]} colorScheme={colorScheme.replace(/est$/, '')} scale={scale} locale={locale} typekitId="pbi5ojv">
<View margin="size-100">
<h1 style={{margin: 0, padding: 0}}>{`${colorScheme}, ${scale}, ${locale}`}</h1>
{getStory(context)}
</View>
</Provider>
)
)
)}
{options.express !== false &&
<Provider key="express" theme={expressTheme} colorScheme={expressColorScheme} scale={expressScale} locale={expressLocale} typekitId="pbi5ojv">
<View margin="size-100">
<h1 style={{margin: 0, padding: 0}}>express, {expressColorScheme}, {expressScale}, {expressLocale}</h1>
{getStory(context)}
</View>
</Provider>
}
</div>
</DisableAnimations>
)
}

function DisableAnimations({children, disableAnimations}) {
useEffect(() => {
if (disableAnimations) {
Expand Down
10 changes: 7 additions & 3 deletions .chromatic/main.js
Original file line number Diff line number Diff line change
@@ -1,9 +1,13 @@

module.exports = {
core: {
builder: "storybook-builder-parcel",
framework: {
name: "storybook-react-parcel",
options: {},
},
stories: ['../packages/**/chromatic/**/*.chromatic.{js,jsx,ts,tsx}'],
stories: [
'../packages/**/chromatic/**/*.stories.@(js|jsx|ts|tsx)',
'../packages/@react-spectrum/s2/chromatic/*.stories.@(js|jsx|mjs|ts|tsx)'
],
addons: process.env.NODE_ENV === 'production' ? [] : [
'@storybook/addon-actions',
'@storybook/addon-a11y'
Expand Down
8 changes: 5 additions & 3 deletions .chromatic/manager.js
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
import addons from '@storybook/addons';
import {addons} from '@storybook/manager-api';

addons.setConfig({
showRoots: false,
enableShortcuts: false
enableShortcuts: false,
sidebar: {
showRoots: false,
}
});
Loading
Loading