chore: add native fdb library to path #2045

NathanFlurry · 2025-02-19T02:59:31Z

Changes

NathanFlurry · 2025-02-19T02:59:52Z

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

How to use the Graphite Merge Queue

Add the label merge-queue to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

_{An organization admin has enabled the Graphite Merge Queue in this repository.} _{Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.}

This stack of pull requests is managed by Graphite. Learn more about stacking.

greptile-apps

PR Summary

This PR enhances cross-platform library path handling in shell.nix, focusing on proper FoundationDB integration across Darwin and Linux systems.

Added platform-specific library path variables (DYLD_LIBRARY_PATH for Darwin, LD_LIBRARY_PATH for Linux) in /shell.nix
Implemented conditional FoundationDB library path handling based on platform support
Added fallback system library path (/usr/local/lib) when FoundationDB is not supported

_{1 file(s) reviewed, 1 comment(s)}
_{Edit PR Review Bot Settings | Greptile}

greptile-apps · 2025-02-19T03:00:08Z

shell.nix

 			'' else ''
 				# Manually check the FDB version
 				if [ -z "$(command -v fdbcli)" ]; then
 					echo "WARNING: FoundationDB CLI is not installed. Please install FoundationDB 7.1."
 				elif ! fdbcli --version 2>/dev/null | grep -q "FoundationDB CLI 7.1"; then
 					echo "WARNING: FoundationDB CLI version is incorrect. Please install FoundationDB 7.1."
 				fi
+
+				# Give access to system libraries
+				export LIBRARY_PATH="/usr/local/lib:$LIBRARY_PATH"


style: Consider prepending to LIBRARY_PATH instead of appending to ensure system libraries don't override package libraries

cloudflare-workers-and-pages · 2025-02-19T03:05:51Z

Deploying rivet with Cloudflare Pages

Latest commit:	`030a024`
Status:	⚡️ Build in progress...

View logs

cloudflare-workers-and-pages · 2025-02-19T03:08:19Z

Deploying rivet-hub with Cloudflare Pages

Latest commit:	`030a024`
Status:	✅ Deploy successful!
Preview URL:	https://5776a49f.rivet-hub-7jb.pages.dev
Branch Preview URL:	https://graphite-base-2049.rivet-hub-7jb.pages.dev

View logs

cloudflare-workers-and-pages · 2025-02-20T22:01:51Z

Deploying rivet with Cloudflare Pages

Latest commit:	`030a024`
Status:	⚡️ Build in progress...

View logs

cloudflare-workers-and-pages · 2025-02-20T22:13:35Z

Deploying rivet with Cloudflare Pages

Latest commit:	`030a024`
Status:	🚫 Build failed.

View logs

cloudflare-workers-and-pages · 2025-02-20T22:14:14Z

Deploying rivet with Cloudflare Pages

Latest commit:	`030a024`
Status:	🚫 Build failed.

View logs

This was referenced Feb 19, 2025

fix: get actors running e2e on edge #2027

Open

fix: get edge api access over gg #2032

Open

feat(workflows): abstract debug trait #2033

Open

This was referenced Feb 19, 2025

feat(workflows): impl db debug for fdb driver #2040

Open

chore: add fdb-backed sqlite driver #2046

Open

greptile-apps bot reviewed Feb 19, 2025

View reviewed changes

NathanFlurry changed the base branch from 02-15-feat_workflows_abstract_debug_trait to graphite-base/2045 February 19, 2025 05:16

NathanFlurry force-pushed the 02-18-chore_add_native_fdb_library_to_path branch from e832d02 to 8061121 Compare February 19, 2025 05:16

NathanFlurry changed the base branch from graphite-base/2045 to chore_add_timeout_flag_to_docker-compose_down February 19, 2025 05:17

This was referenced Feb 19, 2025

chore: add timeout flag to docker-compose down #2048

Open

fix: force amd64 platform for FDB tests #2049

Open

MasterPtato force-pushed the chore_add_timeout_flag_to_docker-compose_down branch from ebd711a to c85f6e8 Compare February 19, 2025 20:26

MasterPtato force-pushed the 02-18-chore_add_native_fdb_library_to_path branch from 8061121 to ef80531 Compare February 19, 2025 20:26

This was referenced Feb 19, 2025

feat: add fdb cli #2051

Open

fix: move actor state to fdb #2056

Open

MasterPtato force-pushed the chore_add_timeout_flag_to_docker-compose_down branch from c85f6e8 to fdf864b Compare February 20, 2025 01:56

MasterPtato force-pushed the 02-18-chore_add_native_fdb_library_to_path branch from ef80531 to 030a024 Compare February 20, 2025 01:56

chore: add native fdb library to path

ba236f2

NathanFlurry force-pushed the 02-18-chore_add_native_fdb_library_to_path branch from 030a024 to ba236f2 Compare February 20, 2025 02:28

MasterPtato force-pushed the chore_add_timeout_flag_to_docker-compose_down branch from 60ffaa2 to fdf864b Compare February 20, 2025 02:37

MasterPtato force-pushed the 02-18-chore_add_native_fdb_library_to_path branch from ba236f2 to 030a024 Compare February 20, 2025 02:37

MasterPtato mentioned this pull request Feb 20, 2025

feat(workflows): implement metrics for fdb driver #2057

Open

NathanFlurry force-pushed the 02-18-chore_add_native_fdb_library_to_path branch from 030a024 to ba236f2 Compare February 20, 2025 02:55

NathanFlurry changed the base branch from chore_add_timeout_flag_to_docker-compose_down to graphite-base/2045 February 20, 2025 03:50

This was referenced Feb 20, 2025

fix(docker): fix corepack not enabled error #2058

Open

feat: add support for JSON5/JSONC config files #2059

Open

chore: add basic load test #2060

Open

MasterPtato force-pushed the graphite-base/2045 branch from 60ffaa2 to fdf864b Compare February 20, 2025 22:01

MasterPtato force-pushed the 02-18-chore_add_native_fdb_library_to_path branch from ba236f2 to 030a024 Compare February 20, 2025 22:01

MasterPtato mentioned this pull request Feb 20, 2025

fix(workflows): fix activity error backoff, in memory polling #2062

Open

MasterPtato mentioned this pull request Feb 21, 2025

fix(fdb): conflict ranges #2063

Open

MasterPtato changed the base branch from graphite-base/2045 to chore_add_timeout_flag_to_docker-compose_down February 21, 2025 02:27

NathanFlurry force-pushed the 02-18-chore_add_native_fdb_library_to_path branch from 030a024 to ba236f2 Compare February 21, 2025 05:17

NathanFlurry mentioned this pull request Feb 21, 2025

fix(job-runner): fix build pack in job-runner Dockerfile #2064

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: add native fdb library to path #2045

chore: add native fdb library to path #2045

NathanFlurry commented Feb 19, 2025

NathanFlurry commented Feb 19, 2025 •

edited

Loading

greptile-apps bot left a comment

greptile-apps bot Feb 19, 2025

cloudflare-workers-and-pages bot commented Feb 19, 2025 •

edited

Loading

cloudflare-workers-and-pages bot commented Feb 19, 2025 •

edited

Loading

cloudflare-workers-and-pages bot commented Feb 20, 2025

cloudflare-workers-and-pages bot commented Feb 20, 2025

cloudflare-workers-and-pages bot commented Feb 20, 2025

chore: add native fdb library to path #2045

Are you sure you want to change the base?

chore: add native fdb library to path #2045

Conversation

NathanFlurry commented Feb 19, 2025

Changes

NathanFlurry commented Feb 19, 2025 • edited Loading

How to use the Graphite Merge Queue

greptile-apps bot left a comment

Choose a reason for hiding this comment

PR Summary

greptile-apps bot Feb 19, 2025

Choose a reason for hiding this comment

cloudflare-workers-and-pages bot commented Feb 19, 2025 • edited Loading

Deploying rivet with Cloudflare Pages

cloudflare-workers-and-pages bot commented Feb 19, 2025 • edited Loading

Deploying rivet-hub with Cloudflare Pages

cloudflare-workers-and-pages bot commented Feb 20, 2025

Deploying rivet with Cloudflare Pages

cloudflare-workers-and-pages bot commented Feb 20, 2025

Deploying rivet with Cloudflare Pages

cloudflare-workers-and-pages bot commented Feb 20, 2025

Deploying rivet with Cloudflare Pages

NathanFlurry commented Feb 19, 2025 •

edited

Loading

cloudflare-workers-and-pages bot commented Feb 19, 2025 •

edited

Loading

cloudflare-workers-and-pages bot commented Feb 19, 2025 •

edited

Loading