feat(workflows): implement metrics for fdb driver #2057
+176
−73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying rivet with
|
| Latest commit: |
c5b7bb3
|
| Status: | 🚫 Build failed. |
This was referenced Feb 20, 2025
NathanFlurry
force-pushed
the
02-20-feat_workflows_implement_metrics_for_fdb_driver
branch
from
c521a04 to
729d516
Compare
NathanFlurry
force-pushed
the
02-20-fix_move_actor_state_to_fdb
branch
from
8412313 to
1b5874e
Compare
This was referenced Feb 20, 2025
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR implements metrics collection for the FDB (FoundationDB) driver in the workflow system, focusing on workflow state tracking and performance monitoring. Here's a concise summary of the key changes:
- Added
DataSubspaceKeyand workflow state tracking structures to monitor workflow lifecycle states (Complete, Running, Sleeping, Dead) - Implemented metrics collection in
publish_metrics()to track total, active, dead, and sleeping workflows with proper reset functionality - Made
PendingSignalSubspaceKey::new()public and improved key handling for better metrics access - Added workflow state detection based on workflow keys and improved error handling for metrics collection
- Implemented proper locking mechanism for metrics publishing to prevent concurrent updates
The changes provide a robust foundation for monitoring workflow performance and state transitions in the FDB driver.
4 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings | Greptile
Comment on lines
+424
to
+441
| } else if let WorkflowState::Dead = current_state { | ||
| if let Ok(_) = self | ||
| .subspace | ||
| .unpack::<keys::workflow::OutputChunkKey>(entry.key()) | ||
| { | ||
| current_state = WorkflowState::Complete; | ||
| } else if let Ok(_) = self | ||
| .subspace | ||
| .unpack::<keys::workflow::WorkerInstanceIdKey>(entry.key()) | ||
| { | ||
| current_state = WorkflowState::Running; | ||
| } else if let Ok(_) = self | ||
| .subspace | ||
| .unpack::<keys::workflow::HasWakeConditionKey>(entry.key()) | ||
| { | ||
| current_state = WorkflowState::Sleeping; | ||
| } | ||
| } |
There was a problem hiding this comment.
logic: State transition logic doesn't handle the case where multiple state indicators exist simultaneously - could lead to incorrect metrics
NathanFlurry
changed the base branch from
02-20-fix_move_actor_state_to_fdb
to
graphite-base/2057
MasterPtato
force-pushed
the
graphite-base/2057
branch
from
1b5874e to
4b4e6ae
Compare
MasterPtato
force-pushed
the
02-20-feat_workflows_implement_metrics_for_fdb_driver
branch
from
729d516 to
c5b7bb3
Compare
This was referenced Feb 20, 2025
MasterPtato
changed the base branch from
graphite-base/2057
to
02-20-fix_move_actor_state_to_fdb
NathanFlurry
force-pushed
the
02-20-feat_workflows_implement_metrics_for_fdb_driver
branch
from
c5b7bb3 to
729d516
Compare
NathanFlurry
force-pushed
the
02-20-fix_move_actor_state_to_fdb
branch
from
4b4e6ae to
1b5874e
Compare
Deploying rivet-hub with
|
| Latest commit: |
729d516
|
| Status: | ⚡️ Build in progress... |
Deploying rivet with
|
| Latest commit: |
729d516
|
| Status: | 🚫 Build failed. |
Deploying rivet-hub with
|
| Latest commit: |
729d516
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://64a6d5ba.rivet-hub-7jb.pages.dev |
| Branch Preview URL: | https://02-20-feat-workflows-impleme.rivet-hub-7jb.pages.dev |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes