chore: disable otel #2244
chore: disable otel #2244
Conversation
How to use the Graphite Merge QueueAdd the label merge-queue to this PR to add it to the merge queue. You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
Deploying rivet with
|
| Latest commit: |
e5b4079
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://2ed27c53.rivet.pages.dev |
| Branch Preview URL: | https://03-21-chore-disable-otel.rivet.pages.dev |
NathanFlurry
changed the base branch from
03-12-chore_examples_add_asteroids_example
to
graphite-base/2244
NathanFlurry
force-pushed
the
graphite-base/2244
branch
from
d16645e to
4dec3ef
Compare
NathanFlurry
force-pushed
the
03-21-chore_disable_otel
branch
from
247e69d to
0a69d99
Compare
Deploying rivet-hub with
|
| Latest commit: |
e5b4079
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://c26902bb.rivet-hub-7jb.pages.dev |
| Branch Preview URL: | https://03-21-chore-disable-otel.rivet-hub-7jb.pages.dev |
NathanFlurry
force-pushed
the
03-21-chore_disable_otel
branch
2 times, most recently
from
6454908 to
2093976
Compare
NathanFlurry
force-pushed
the
03-21-chore_disable_otel
branch
from
2093976 to
e5b4079
Compare
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR makes significant changes to disable OpenTelemetry functionality across the Rivet codebase. Here's a summary of the key changes:
- Updates root Cargo.toml to use Tokio 1.44.0 with
fullandtracingfeatures enabled at workspace level - Disables OpenTelemetry in runtime/src/otel.rs by commenting out tracer and meter provider initialization
- Adds Tokio console support via new
TOKIO_CONSOLE_ENABLEenvironment variable - Adds tokio_console.sh script for port forwarding the Tokio console service
Key points to consider:
- Workspace-level Tokio configuration ensures consistent versioning but requires careful verification that all necessary features are included
- Telemetry functionality is being replaced with alternative monitoring through Tokio console
- The changes maintain existing logging through logfmt while removing OpenTelemetry layers
- OpenTelemetry code is commented out rather than removed, suggesting this may be temporary
The changes appear well-structured but should be tested thoroughly to ensure monitoring capabilities remain sufficient without OpenTelemetry.
68 file(s) reviewed, 3 comment(s)
Edit PR Review Bot Settings | Greptile
| [workspace.dependencies.tokio] | ||
| version = "1.40.0" | ||
| default-features = false | ||
| features = ["full"] | ||
| version = "1.44.0" | ||
| features = ["full", "tracing"] |
There was a problem hiding this comment.
style: Enabling default features could introduce unnecessary dependencies - consider keeping default-features = false and explicitly listing required features
| pub struct OtelGuard { | ||
| tracer_provider: SdkTracerProvider, | ||
| meter_provider: SdkMeterProvider, | ||
| //tracer_provider: SdkTracerProvider, | ||
| //meter_provider: SdkMeterProvider, | ||
| //logger_provider: SdkLoggerProvider, | ||
| } |
There was a problem hiding this comment.
style: Empty struct could be replaced with unit struct pub struct OtelGuard; since it no longer contains any fields
| pub struct OtelGuard { | |
| tracer_provider: SdkTracerProvider, | |
| meter_provider: SdkMeterProvider, | |
| //tracer_provider: SdkTracerProvider, | |
| //meter_provider: SdkMeterProvider, | |
| //logger_provider: SdkLoggerProvider, | |
| } | |
| pub struct OtelGuard; |
| "test-util", | ||
| "time", | ||
| ] } | ||
| tokio.workspace = true |
There was a problem hiding this comment.
style: Consider keeping explicit feature flags in this package to make dependencies more transparent and avoid unintended feature changes from workspace updates
Changes