chore: update reqwest client #2249
Conversation
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
How to use the Graphite Merge QueueAdd the label merge-queue to this PR to add it to the merge queue. You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR centralizes and standardizes HTTP client configuration by introducing a shared reqwest client pool in rivet-pools, affecting multiple services across the codebase.
- Added new
packages/common/pools/src/reqwest.rswith a static OnceCell client configured with 30-second timeout - Added reqwest 0.11 as direct dependency in
packages/common/pools/Cargo.tomlrather than through workspace - TODO comments in
nomad-util/src/lib.rsindicate async client initialization needs proper implementation - Updated Configuration structs across multiple services to use the shared client from
rivet_pools::reqwest::client() - Potential issue with async/sync mismatch in nomad-util functions that need refactoring
10 file(s) reviewed, 2 comment(s)
Edit PR Review Bot Settings | Greptile
| @@ -34,6 +34,7 @@ url = "2.4" | |||
| uuid = { version = "1", features = ["v4"] } | |||
| scc = "2.3.3" | |||
| tokio-native-tls = "0.3.1" | |||
| reqwest = "0.11" | |||
There was a problem hiding this comment.
style: Consider using workspace version for reqwest like other dependencies to maintain consistency across the project
| .build() | ||
| }) | ||
| .await | ||
| .cloned() |
There was a problem hiding this comment.
style: Using clone() on each client request could be inefficient - consider returning a reference instead since Client is already Arc-based
| .cloned() | |
| .await |
Deploying rivet with
|
| Latest commit: |
569b905
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://48cf07cd.rivet.pages.dev |
| Branch Preview URL: | https://03-22-chore-update-reqwest-c.rivet.pages.dev |
Merge activity
|
<!-- Please make sure there is an issue that this PR is correlated to. --> ## Changes <!-- If there are frontend changes, please include screenshots. -->
Changes