BREAKING CHANGE: set default period for linux_gpios to 0.1 #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the edge triggered functionality only really works when the edge_triggered_output flag is true and the connection has the `init: true` flag, so the keep_last_written_value can be kept as true by default without major drawbacks.
organize tests into general functionality and tests for init: true, which need a particular setup the "fails to configure if a GPIO does not exist" was duplicated
fixes the break_and_reestablish_connection function gives better and more descriptive names to the tasks simplifies tests code cleaning in general
test: test edge trigger property with init: true connection
A heisenbug was happening in the "does not keep last written value when a new connection is established with 'init: false'" test. The test expected no samples, but got 1. This was due to how the test was structured, specifically the fact that the write and the disconnect-connect block of code were inside the same expect_execution block, causing a race condition. The tests were also simplified by using a data_reader instead of the previous, unnecessary complicated, setup.
fix: fix heisenbug and simplify tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The objective of this PR is NOT to merge the change, which would silently break systems. We'll be using this branch for testing on our systems and devise another way to change the period in a non-backward-breaking way