Adjust monitor-net settings #118
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frenchu
commented
Feb 18, 2024
| @@ -20,8 +20,8 @@ services: | |||
| - "{{.RocketPoolDirectory}}/grafana-prometheus-datasource.yml:/etc/grafana/provisioning/datasources/prometheus.yml" | |||
| - "grafana-storage:/var/lib/grafana" | |||
| networks: | |||
| - net | |||
| - monitor-net | |||
There was a problem hiding this comment.
Run Grafana service in monitor-net for better network isolation.
| @@ -28,16 +28,7 @@ services: | |||
| extra_hosts: | |||
| - "host.docker.internal:host-gateway" | |||
| networks: | |||
| # Bridge so node-exporter can get the real NIC details | |||
| # See https://stackoverflow.com/a/66689508 for more info | |||
There was a problem hiding this comment.
The stackoverflow solution refered in the comment is obselete by now. Adding "host.docker.internal:host-gateway" as an extra host is enough alone. The stackoverflow answer was updated to reflect that.
| ipam: | ||
| driver: default | ||
| config: | ||
| - subnet: 172.23.0.0/16 |
There was a problem hiding this comment.
The RocketPool docs don't assume any particular network address for monitoring, so docker compose can assign network address for monitor-net by itself. The network address should not change later during RP node operation, since the networks are not recreated on starting/stopping RocketPool services. For current node operators the address will also not change.
frenchu
force-pushed
the
adjust_monitor-net
branch
from
ca89d7a to
e446d95
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Assigning a static address for monitor-net can lead to an issue. User can run other compose projects and create custom networks. By default docker will assign random network addresses automatically. When user already has a docker network with the same address as monitor-net address, rocketpool services are not starting:
Moreover, Grafana service can be isolated from containers in rocketpool_net and connected to monitor-net with Prometheus service.
More details in the pull request comments.