Skip to content

Adjust monitor-net settings #118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Adjust monitor-net settings #118

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions install/templates/grafana.tmpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,8 @@ services:
- "{{.RocketPoolDirectory}}/grafana-prometheus-datasource.yml:/etc/grafana/provisioning/datasources/prometheus.yml"
- "grafana-storage:/var/lib/grafana"
networks:
- net
- monitor-net
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Run Grafana service in monitor-net for better network isolation.

networks:
net:
monitor-net:
volumes:
grafana-storage:
9 changes: 0 additions & 9 deletions install/templates/prometheus.tmpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,16 +28,7 @@ services:
extra_hosts:
- "host.docker.internal:host-gateway"
networks:
# Bridge so node-exporter can get the real NIC details
# See https://stackoverflow.com/a/66689508 for more info
Copy link
Author

@frenchu frenchu Feb 18, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The stackoverflow solution refered in the comment is obselete by now. Adding "host.docker.internal:host-gateway" as an extra host is enough alone. The stackoverflow answer was updated to reflect that.

monitor-net:
driver: bridge
ipam:
driver: default
config:
- subnet: 172.23.0.0/16
Copy link
Author

@frenchu frenchu Feb 18, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The RocketPool docs don't assume any particular network address for monitoring, so docker compose can assign network address for monitor-net by itself. The network address should not change later during RP node operation, since the networks are not recreated on starting/stopping RocketPool services. For current node operators the address will also not change.

ip_range: 172.23.5.0/24
gateway: 172.23.5.254
net:
volumes:
prometheus-data: