Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add Halkomelem APA/Hul’q’umi’num’ mapping #413

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

goodzack
Copy link

@goodzack goodzack commented Jan 9, 2025

Hul’q‛umi’num’ is the Island dialect of Halkomelem. This mapping is between APA used to transcribe Salish languages and the Hul’q’umi’num’ practical orthography.

Pull request template for adding a new language

  • Please check if the PR fulfills these requirements
  • [x ] Mapping files are added in g2p/mappings/langs
  • [x ] Mapping is either added to an existing folder or a new folder has been added
  • [x ] Language folder and files use appropriate ISO 639-3 codes
  • [x ] config-g2p.yaml file includes all author names, and settings necessary
  • [x ] Please add some test data in g2p/tests/public/data. The added file should be a csv/tsv/psv file and each row should have the format [input_mapping_code,output_mapping_code,input_string,output_string]
  • [x ] As the last step, G2P has been updated by running g2p update locally and committing the change
  • [x ] You agree to license your contribution under the same license as this project (see LICENSE file).
  • Other information:
    Cheers 😛

Hul’q‛umi’num’ is the Island dialect of Halkomelem.
This mapping is between APA used to transcribe Salish languages
and the Hul’q’umi’num’ practical orthography.
@roedoejet
Copy link
Owner

Hul’q‛umi’num’ is the Island dialect of Halkomelem. This mapping is between APA used to transcribe Salish languages and the Hul’q’umi’num’ practical orthography.

Pull request template for adding a new language

  • Please check if the PR fulfills these requirements

  • [x ] Mapping files are added in g2p/mappings/langs

  • [x ] Mapping is either added to an existing folder or a new folder has been added

  • [x ] Language folder and files use appropriate ISO 639-3 codes

  • [x ] config-g2p.yaml file includes all author names, and settings necessary

  • [x ] Please add some test data in g2p/tests/public/data. The added file should be a csv/tsv/psv file and each row should have the format [input_mapping_code,output_mapping_code,input_string,output_string]

  • [x ] As the last step, G2P has been updated by running g2p update locally and committing the change

  • [x ] You agree to license your contribution under the same license as this project (see LICENSE file).

  • Other information:
    Cheers 😛

Very very cool! We'll have a look at this soon, thanks @goodzack !

@roedoejet roedoejet requested review from roedoejet and joanise January 9, 2025 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants