Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

113 feature configue exclusion of building amenities #114

Merged

Conversation

clint156
Copy link
Collaborator

@clint156 clint156 commented Nov 4, 2024

Description

The change pulls a list of known building features from the database and uses that to filter the features coming back from campus queries down to the smaller list we wish to display on the building details panel.

**Resolves #113 **

Review Time Estimate

  • [x ] Immediately
  • Within a week
  • When possible

Type of changes

Please select a relevant option:

  • Bug fix (non-breaking change which fixes an issue).
  • [ x] New feature (non-breaking change which adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to not work as expected).
  • Other (any another change that does not fall in one of the above categories.)

Checklist:

Please select all applicable options:

  • I have signed the Rokwire Contributor License Agreement (CLA). (Any contributor who is not an employee of the University of Illinois whose official duties include contributing to the Rokwire software, or who is not paid by the Rokwire project, needs to sign the CLA before their contribution can be accepted.)
  • I have updated the CHANGELOG.
  • I have read the Contributor Guidelines.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • My change requires updating the documentation.
  • I have made necessary changes to the documentation.
  • I have added tests related to my changes.
  • My changes generate no new warnings.
  • New and existing unit tests pass locally with my changes.
  • Any dependent changes have been merged and published in downstream modules.

@clint156 clint156 self-assigned this Nov 4, 2024
@clint156 clint156 linked an issue Nov 4, 2024 that may be closed by this pull request
@clint156 clint156 merged commit 26a9960 into develop Nov 4, 2024
2 checks passed
@clint156 clint156 deleted the 113-feature-configue-exclusion-of-building-amenities branch November 4, 2024 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Configue exclusion of building amenities
1 participant