update to use non deprecated pluginlib macro #56
Conversation
|
Thanks for catching this! CI passes except for the one on ROS buildfarm. Looks like it hasn't passed for awhile e.g. #52 but I won't have time to look into this in a foreseeable period. |
|
Looks like the job on the buildfarms are failing because of warnings http://build.ros.org/job/Lpr__openni_camera__ubuntu_xenial_amd64/2/warnings22Result/. Unrelated to this change AFAICT |
|
Ok, then merging. |
|
For buildfarm CI failure, besides that it happens at other repos too, it wouldn't be useful if the actual status and the result notifier is not the same. So asked question. |
|
Got an answer to the question #56 (comment), and turned out the warnings that caused the CI error is already tracked #51 (^o^;) |
As ros-drivers/openni_camera#56 (comment), test might always fail on GitHub for UNSTABLE, which makes the maintenance harder.
* [IKL] Merge openni_{camera, launch} into a single repo.
Following the decision in ros-drivers/openni_launch#30
* [IKL] openni_camera version adjust to release repo.
* [openni_camera][lunar] Disable source test.
As ros-drivers/openni_camera#56 (comment), test might always fail on GitHub for UNSTABLE, which makes the maintenance harder.
These macros, deprecated for now 8 years, will be removed in the next ROS release (ROS Melodic)
This change will allow the code to keep compiling on future ROS versions