Skip to content

Conversation

@Briancbn
Copy link
Member

@Briancbn Briancbn commented Nov 8, 2025

This PR enables GHA for this repo

Key changes

  • Add in missing $ when trying to unpack matrix.env. This is the main cause that the CI was not running.
  • Add in ICI shell isolation. This is needed if we let GHA manage container, instead of directly running on runs-on.
  • Small changes to the cpplint configuration. For some reason, ICI attempt to use the full path for ament_cpplint for the test directory (ref). Let me know your thoughts on this.

@Briancbn Briancbn changed the title ci(GHA): fix missing $ character in CI config ci(GHA): fix CI config typo and failure Nov 8, 2025
@Briancbn Briancbn marked this pull request as draft November 8, 2025 01:30
@Briancbn Briancbn marked this pull request as ready for review November 8, 2025 01:56
@Briancbn Briancbn requested a review from sauk2 November 8, 2025 01:57
Copy link
Member

@sauk2 sauk2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Thanks for fixing the CI. I am merging this in 🚀

@sauk2 sauk2 merged commit 7ef1734 into main Nov 10, 2025
2 checks passed
@sauk2 sauk2 deleted the fix/fix-ci branch November 10, 2025 02:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants