Skip to content

ci(GHA): fix CI config typo and failure #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sauk2 merged 4 commits into from
Nov 10, 2025
Merged

ci(GHA): fix CI config typo and failure #18

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
71d8130
ci(GHA): fix missing $ character in CI config
Briancbn Nov 8, 2025
71a0ad1
ci(ici): add config for shell isolation
Briancbn Nov 8, 2025
ae87e43
lint(cpplint): remove config for forcing cpplint to run only in include
Briancbn Nov 8, 2025
871a4b7
lint(cpplint): update header guard for the new config
Briancbn Nov 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,10 +20,12 @@ jobs:
ADDITIONAL_DEBS: clang lld
CC: "clang"
CXX: "clang++"
env:
ISOLATION: "shell"
runs-on: ubuntu-latest
container:
image: ros:jazzy-ros-core
steps:
- uses: actions/checkout@v4
- uses: 'ros-industrial/industrial_ci@master'
env: {{ matrix.env }}
env: ${{ matrix.env }}
5 changes: 0 additions & 5 deletions CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,13 +89,8 @@ if(BUILD_TESTING)
set(cpplint_filters
"-whitespace/newline"
)
set(cpplint_root_paths
"${CMAKE_CURRENT_SOURCE_DIR}/include/"
)

ament_cpplint(
FILTERS "${cpplint_filters}"
ROOT "${cpplint_root_paths}"
)

find_package(ament_cmake_clang_format REQUIRED)
Expand Down
6 changes: 3 additions & 3 deletions test/generator/generator.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,8 @@
* limitations under the License.
*/

#ifndef TEST__GENERATOR__GENERATOR_HPP_
#define TEST__GENERATOR__GENERATOR_HPP_
#ifndef GENERATOR__GENERATOR_HPP_
#define GENERATOR__GENERATOR_HPP_

#include <limits>
#include <random>
Expand Down Expand Up @@ -1000,4 +1000,4 @@ class RandomDataGenerator
uint8_t ORDER_VECTOR_SIZE_UPPER_BOUND = 10;
};

#endif // TEST__GENERATOR__GENERATOR_HPP_
#endif // GENERATOR__GENERATOR_HPP_