Deprecated spin_until_future_complete #90
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Due to change in RCLCPP - ros2/rclcpp#1874 Pull request |
|
ros2/rclcpp#1874 (comment) Passing CI with all related PRs linked and build together. |
…lete` Signed-off-by: Hubert Liberacki <[email protected]>
hliberacki
force-pushed
the
hliberacki/spin_until
branch
from
5b24985 to
cf90495
Compare
SteveMacenski
approved these changes
Jun 24, 2022
fujitatomoya
approved these changes
Jul 19, 2022
|
This PR was merged and caused multiple errors along Rolling CI builds: If I'm not wrong, this change was waiting until a pack of other PRs on multiple repositories (ros2/rclcpp#1874 (comment)). @dgossow was there any reason I'm not seeing to merge this PR right now? |
|
I think we should wait until ros2/rclcpp#1957 lands ( |
Crola1702
added a commit
to Crola1702/interactive_markers
that referenced
this pull request
Oct 26, 2023
This reverts commit 320c2a3. As stated in: ros-visualization#90 (comment)
Crola1702
added a commit
to Crola1702/interactive_markers
that referenced
this pull request
Oct 26, 2023
…til_complete` (ros-visualization#90)" This reverts commit 71212ef. As stated in ros-visualization#90 (comment)
clalancette
pushed a commit
that referenced
this pull request
Oct 26, 2023
…til_complete` (#90)" (#104) This reverts commit 71212ef. As stated in #90 (comment)
christophebedard
added a commit
to christophebedard/interactive_markers
that referenced
this pull request
Apr 2, 2024
…lete` (ros-visualization#90) Co-authored-by: Hubert Liberacki <[email protected]> Signed-off-by: Hubert Liberacki <[email protected]> Signed-off-by: Christophe Bedard <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace deprecated
spin_until_future_completewithspin_until_completeSigned-off-by: Hubert Liberacki [email protected]