Create turtlesim_msgs #169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alejandro Hernandez Cordero <[email protected]>
clalancette
requested changes
Jun 27, 2024
There was a problem hiding this comment.
Ah, this is a good idea.
I've left one nit inline.
Besides that, we'll have to update all of the code in https://github.com/ros/geometry_tutorials/tree/ros2 to deal with this change. Which also means we'll have to make branches in that repository, since we won't be able to backport this to Jazzy, Iron, and Humble.
We'll also have to update the documentation in https://github.com/ros2/ros2_documentation/, only on the rolling branch.
Signed-off-by: Alejandro Hernández Cordero <[email protected]>
|
|
PR updating the documentation ros2/ros2_documentation#4562 |
Signed-off-by: Alejandro Hernández Cordero <[email protected]>
|
clalancette
approved these changes
Jul 9, 2024
There was a problem hiding this comment.
Looks good, this should be merged in tandem with ros/geometry_tutorials#78 and ros2/ros2_documentation#4562
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's more clear when messages and code are in different packages