Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closing launch file if required composable node shuts down #224

Open
ksuszka opened this issue Apr 1, 2021 · 0 comments
Open

Closing launch file if required composable node shuts down #224

ksuszka opened this issue Apr 1, 2021 · 0 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@ksuszka
Copy link

ksuszka commented Apr 1, 2021

Feature request

Feature description

ROS1 launch system has "required" parameter. In ROS2 launch system the same functionality can be implemented using on_exit event. However this only works for standalone executables. It would be nice to have the same functionality for composable nodes.

Implementation considerations

At the moment we implemented ugly workaround. We periodically check list of nodes in a composable container and shutdown the launch process if required nodes are missing.

@clalancette clalancette added the enhancement New feature or request label Apr 22, 2021
@nuclearsandwich nuclearsandwich added the help wanted Extra attention is needed label Apr 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants