add cpp version for urdf_tutorial #4926
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
some command to launch debug demo is wrong and correct it Signed-off-by: Demonmasterlqx <[email protected]>
Signed-off-by: Demonmasterlqx <[email protected]>
…obot-State-Publisher-py.rst change name Signed-off-by: Demonmasterlqx <[email protected]>
add cpp version Signed-off-by: Demonmasterlqx <[email protected]>
add
.. redirect-from::
Tutorials/URDF/Using-URDF-with-Robot-State-Publisher
Signed-off-by: Demonmasterlqx <[email protected]>
kscottz
requested changes
Jan 8, 2025
There was a problem hiding this comment.
Hi @Demonmasterlqx, thank you so much for your contribution! We really appreciate it.
I sent over a bunch of suggestions. Before I approve this I would like to see more comments in main C++ source file. It really helps users when we document the example code in excruciating detail.
Other than that I think we have to discuss the copyright of the code cited in pull request. I don't think it is a problem, but we need some clarity on how to handle it appropriately.
source/Tutorials/Intermediate/URDF/Using-URDF-with-Robot-State-Publisher-cpp.rst
Outdated
Show resolved
Hide resolved
source/Tutorials/Intermediate/URDF/Using-URDF-with-Robot-State-Publisher-cpp.rst
Outdated
Show resolved
Hide resolved
source/Tutorials/Intermediate/URDF/Using-URDF-with-Robot-State-Publisher-cpp.rst
Outdated
Show resolved
Hide resolved
source/Tutorials/Intermediate/URDF/Using-URDF-with-Robot-State-Publisher-cpp.rst
Show resolved
Hide resolved
source/Tutorials/Intermediate/URDF/Using-URDF-with-Robot-State-Publisher-cpp.rst
Outdated
Show resolved
Hide resolved
source/Tutorials/Intermediate/URDF/Using-URDF-with-Robot-State-Publisher-cpp.rst
Outdated
Show resolved
Hide resolved
source/Tutorials/Intermediate/URDF/Using-URDF-with-Robot-State-Publisher-cpp.rst
Show resolved
Hide resolved
source/Tutorials/Intermediate/URDF/Using-URDF-with-Robot-State-Publisher-cpp.rst
Outdated
Show resolved
Hide resolved
source/Tutorials/Intermediate/URDF/Using-URDF-with-Robot-State-Publisher-cpp.rst
Outdated
Show resolved
Hide resolved
Signed-off-by: Demonmasterlqx <[email protected]>
Polish my language Signed-off-by: Demonmasterlqx <[email protected]>
add code comment Signed-off-by: Demonmasterlqx <[email protected]>
fix format problems Signed-off-by: Demonmasterlqx <[email protected]>
|
Hi @kscottz ! Thank you so much for helping me to polish my words and give some suggestion. I have add some code comment into code blocks and polish my words |
kscottz
reviewed
Jan 15, 2025
source/Tutorials/Intermediate/URDF/Using-URDF-with-Robot-State-Publisher-cpp.rst
Outdated
Show resolved
Hide resolved
kscottz
reviewed
Jan 15, 2025
source/Tutorials/Intermediate/URDF/Using-URDF-with-Robot-State-Publisher-cpp.rst
Outdated
Show resolved
Hide resolved
kscottz
approved these changes
Jan 15, 2025
There was a problem hiding this comment.
I went through and added a few suggestions. I'll approve the PR under the assumption that you'll approve those and that you pass the linter.
You had a long list of linter whitespace errors that needed to be fixed. I think I fixed them all for you but there might be a few stragglers.
You need one more review before we can merge this in.
source/Tutorials/Intermediate/URDF/Using-URDF-with-Robot-State-Publisher-cpp.rst
Outdated
Show resolved
Hide resolved
source/Tutorials/Intermediate/URDF/Using-URDF-with-Robot-State-Publisher-cpp.rst
Outdated
Show resolved
Hide resolved
source/Tutorials/Intermediate/URDF/Using-URDF-with-Robot-State-Publisher-cpp.rst
Outdated
Show resolved
Hide resolved
source/Tutorials/Intermediate/URDF/Using-URDF-with-Robot-State-Publisher-cpp.rst
Outdated
Show resolved
Hide resolved
source/Tutorials/Intermediate/URDF/Using-URDF-with-Robot-State-Publisher-cpp.rst
Outdated
Show resolved
Hide resolved
source/Tutorials/Intermediate/URDF/Using-URDF-with-Robot-State-Publisher-cpp.rst
Outdated
Show resolved
Hide resolved
source/Tutorials/Intermediate/URDF/Using-URDF-with-Robot-State-Publisher-cpp.rst
Show resolved
Hide resolved
source/Tutorials/Intermediate/URDF/Using-URDF-with-Robot-State-Publisher-cpp.rst
Outdated
Show resolved
Hide resolved
source/Tutorials/Intermediate/URDF/Using-URDF-with-Robot-State-Publisher-cpp.rst
Outdated
Show resolved
Hide resolved
source/Tutorials/Intermediate/URDF/Using-URDF-with-Robot-State-Publisher-cpp.rst
Outdated
Show resolved
Hide resolved
…-Publisher-cpp.rst Signed-off-by: Katherine Scott <[email protected]>
kscottz
reviewed
Jan 16, 2025
source/Tutorials/Intermediate/URDF/Using-URDF-with-Robot-State-Publisher-cpp.rst
Outdated
Show resolved
Hide resolved
|
friendly ping @Demonmasterlqx |
…-Publisher-cpp.rst Signed-off-by: Katherine Scott <[email protected]>
…-Publisher-cpp.rst Signed-off-by: Katherine Scott <[email protected]>
…-Publisher-cpp.rst Signed-off-by: Katherine Scott <[email protected]>
…-Publisher-cpp.rst Signed-off-by: Katherine Scott <[email protected]>
…-Publisher-cpp.rst Signed-off-by: Katherine Scott <[email protected]>
source/Tutorials/Intermediate/URDF/Using-URDF-with-Robot-State-Publisher-cpp.rst
Outdated
Show resolved
Hide resolved
source/Tutorials/Intermediate/URDF/Using-URDF-with-Robot-State-Publisher-cpp.rst
Outdated
Show resolved
Hide resolved
…-Publisher-cpp.rst Co-authored-by: Christophe Bedard <[email protected]> Signed-off-by: Demonmasterlqx <[email protected]>
…-Publisher-cpp.rst Co-authored-by: Christophe Bedard <[email protected]> Signed-off-by: Demonmasterlqx <[email protected]>
ahcorde
added
the
backport-all
Signed-off-by: Alejandro Hernandez Cordero <[email protected]>
Signed-off-by: Alejandro Hernandez Cordero <[email protected]>
Signed-off-by: Alejandro Hernandez Cordero <[email protected]>
|
@kscottz I made some changes to fix warnings and to make the tutorials visible in the documentation. Feel free to merge it if my changes looks fine |
ahcorde
approved these changes
Feb 14, 2025
mergify bot
pushed a commit
that referenced
this pull request
Feb 24, 2025
* Update Debugging-Tf2-Problems.rst some command to launch debug demo is wrong and correct it Signed-off-by: Demonmasterlqx <[email protected]> * Update Debugging-Tf2-Problems.rst Signed-off-by: Demonmasterlqx <[email protected]> * Rename Using-URDF-with-Robot-State-Publisher.rst to Using-URDF-with-Robot-State-Publisher-py.rst change name Signed-off-by: Demonmasterlqx <[email protected]> * Create Using-URDF-with-Robot-State-Publisher-cpp.rst add cpp version Signed-off-by: Demonmasterlqx <[email protected]> * Update Using-URDF-with-Robot-State-Publisher-cpp.rst add .. redirect-from:: Tutorials/URDF/Using-URDF-with-Robot-State-Publisher Signed-off-by: Demonmasterlqx <[email protected]> * Update Using-URDF-with-Robot-State-Publisher-cpp.rst Signed-off-by: Demonmasterlqx <[email protected]> * Update Using-URDF-with-Robot-State-Publisher-cpp.rst Polish my language Signed-off-by: Demonmasterlqx <[email protected]> * Update Using-URDF-with-Robot-State-Publisher-cpp.rst add code comment Signed-off-by: Demonmasterlqx <[email protected]> * Update Using-URDF-with-Robot-State-Publisher-cpp.rst fix format problems Signed-off-by: Demonmasterlqx <[email protected]> * White space help. * Update source/Tutorials/Intermediate/URDF/Using-URDF-with-Robot-State-Publisher-cpp.rst Signed-off-by: Katherine Scott <[email protected]> * Update source/Tutorials/Intermediate/URDF/Using-URDF-with-Robot-State-Publisher-cpp.rst Signed-off-by: Katherine Scott <[email protected]> * Update source/Tutorials/Intermediate/URDF/Using-URDF-with-Robot-State-Publisher-cpp.rst Signed-off-by: Katherine Scott <[email protected]> * Update source/Tutorials/Intermediate/URDF/Using-URDF-with-Robot-State-Publisher-cpp.rst Signed-off-by: Katherine Scott <[email protected]> * Update source/Tutorials/Intermediate/URDF/Using-URDF-with-Robot-State-Publisher-cpp.rst Signed-off-by: Katherine Scott <[email protected]> * Update source/Tutorials/Intermediate/URDF/Using-URDF-with-Robot-State-Publisher-cpp.rst Signed-off-by: Katherine Scott <[email protected]> * Update source/Tutorials/Intermediate/URDF/Using-URDF-with-Robot-State-Publisher-cpp.rst Co-authored-by: Christophe Bedard <[email protected]> Signed-off-by: Demonmasterlqx <[email protected]> * Update source/Tutorials/Intermediate/URDF/Using-URDF-with-Robot-State-Publisher-cpp.rst Co-authored-by: Christophe Bedard <[email protected]> Signed-off-by: Demonmasterlqx <[email protected]> * codespell Signed-off-by: Alejandro Hernandez Cordero <[email protected]> * Title underline too short Signed-off-by: Alejandro Hernandez Cordero <[email protected]> * make tutorials visible Signed-off-by: Alejandro Hernandez Cordero <[email protected]> --------- Signed-off-by: Demonmasterlqx <[email protected]> Signed-off-by: Katherine Scott <[email protected]> Signed-off-by: Alejandro Hernandez Cordero <[email protected]> Co-authored-by: kscottz <[email protected]> Co-authored-by: Christophe Bedard <[email protected]> Co-authored-by: Alejandro Hernandez Cordero <[email protected]> (cherry picked from commit 228a7b2)
mergify bot
pushed a commit
that referenced
this pull request
Feb 24, 2025
* Update Debugging-Tf2-Problems.rst some command to launch debug demo is wrong and correct it Signed-off-by: Demonmasterlqx <[email protected]> * Update Debugging-Tf2-Problems.rst Signed-off-by: Demonmasterlqx <[email protected]> * Rename Using-URDF-with-Robot-State-Publisher.rst to Using-URDF-with-Robot-State-Publisher-py.rst change name Signed-off-by: Demonmasterlqx <[email protected]> * Create Using-URDF-with-Robot-State-Publisher-cpp.rst add cpp version Signed-off-by: Demonmasterlqx <[email protected]> * Update Using-URDF-with-Robot-State-Publisher-cpp.rst add .. redirect-from:: Tutorials/URDF/Using-URDF-with-Robot-State-Publisher Signed-off-by: Demonmasterlqx <[email protected]> * Update Using-URDF-with-Robot-State-Publisher-cpp.rst Signed-off-by: Demonmasterlqx <[email protected]> * Update Using-URDF-with-Robot-State-Publisher-cpp.rst Polish my language Signed-off-by: Demonmasterlqx <[email protected]> * Update Using-URDF-with-Robot-State-Publisher-cpp.rst add code comment Signed-off-by: Demonmasterlqx <[email protected]> * Update Using-URDF-with-Robot-State-Publisher-cpp.rst fix format problems Signed-off-by: Demonmasterlqx <[email protected]> * White space help. * Update source/Tutorials/Intermediate/URDF/Using-URDF-with-Robot-State-Publisher-cpp.rst Signed-off-by: Katherine Scott <[email protected]> * Update source/Tutorials/Intermediate/URDF/Using-URDF-with-Robot-State-Publisher-cpp.rst Signed-off-by: Katherine Scott <[email protected]> * Update source/Tutorials/Intermediate/URDF/Using-URDF-with-Robot-State-Publisher-cpp.rst Signed-off-by: Katherine Scott <[email protected]> * Update source/Tutorials/Intermediate/URDF/Using-URDF-with-Robot-State-Publisher-cpp.rst Signed-off-by: Katherine Scott <[email protected]> * Update source/Tutorials/Intermediate/URDF/Using-URDF-with-Robot-State-Publisher-cpp.rst Signed-off-by: Katherine Scott <[email protected]> * Update source/Tutorials/Intermediate/URDF/Using-URDF-with-Robot-State-Publisher-cpp.rst Signed-off-by: Katherine Scott <[email protected]> * Update source/Tutorials/Intermediate/URDF/Using-URDF-with-Robot-State-Publisher-cpp.rst Co-authored-by: Christophe Bedard <[email protected]> Signed-off-by: Demonmasterlqx <[email protected]> * Update source/Tutorials/Intermediate/URDF/Using-URDF-with-Robot-State-Publisher-cpp.rst Co-authored-by: Christophe Bedard <[email protected]> Signed-off-by: Demonmasterlqx <[email protected]> * codespell Signed-off-by: Alejandro Hernandez Cordero <[email protected]> * Title underline too short Signed-off-by: Alejandro Hernandez Cordero <[email protected]> * make tutorials visible Signed-off-by: Alejandro Hernandez Cordero <[email protected]> --------- Signed-off-by: Demonmasterlqx <[email protected]> Signed-off-by: Katherine Scott <[email protected]> Signed-off-by: Alejandro Hernandez Cordero <[email protected]> Co-authored-by: kscottz <[email protected]> Co-authored-by: Christophe Bedard <[email protected]> Co-authored-by: Alejandro Hernandez Cordero <[email protected]> (cherry picked from commit 228a7b2) # Conflicts: # source/Tutorials/Intermediate/URDF/URDF-Main.rst
fujitatomoya
pushed a commit
that referenced
this pull request
Feb 24, 2025
* Update Debugging-Tf2-Problems.rst some command to launch debug demo is wrong and correct it Signed-off-by: Demonmasterlqx <[email protected]> * Update Debugging-Tf2-Problems.rst Signed-off-by: Demonmasterlqx <[email protected]> * Rename Using-URDF-with-Robot-State-Publisher.rst to Using-URDF-with-Robot-State-Publisher-py.rst change name Signed-off-by: Demonmasterlqx <[email protected]> * Create Using-URDF-with-Robot-State-Publisher-cpp.rst add cpp version Signed-off-by: Demonmasterlqx <[email protected]> * Update Using-URDF-with-Robot-State-Publisher-cpp.rst add .. redirect-from:: Tutorials/URDF/Using-URDF-with-Robot-State-Publisher Signed-off-by: Demonmasterlqx <[email protected]> * Update Using-URDF-with-Robot-State-Publisher-cpp.rst Signed-off-by: Demonmasterlqx <[email protected]> * Update Using-URDF-with-Robot-State-Publisher-cpp.rst Polish my language Signed-off-by: Demonmasterlqx <[email protected]> * Update Using-URDF-with-Robot-State-Publisher-cpp.rst add code comment Signed-off-by: Demonmasterlqx <[email protected]> * Update Using-URDF-with-Robot-State-Publisher-cpp.rst fix format problems Signed-off-by: Demonmasterlqx <[email protected]> * White space help. * Update source/Tutorials/Intermediate/URDF/Using-URDF-with-Robot-State-Publisher-cpp.rst Signed-off-by: Katherine Scott <[email protected]> * Update source/Tutorials/Intermediate/URDF/Using-URDF-with-Robot-State-Publisher-cpp.rst Signed-off-by: Katherine Scott <[email protected]> * Update source/Tutorials/Intermediate/URDF/Using-URDF-with-Robot-State-Publisher-cpp.rst Signed-off-by: Katherine Scott <[email protected]> * Update source/Tutorials/Intermediate/URDF/Using-URDF-with-Robot-State-Publisher-cpp.rst Signed-off-by: Katherine Scott <[email protected]> * Update source/Tutorials/Intermediate/URDF/Using-URDF-with-Robot-State-Publisher-cpp.rst Signed-off-by: Katherine Scott <[email protected]> * Update source/Tutorials/Intermediate/URDF/Using-URDF-with-Robot-State-Publisher-cpp.rst Signed-off-by: Katherine Scott <[email protected]> * Update source/Tutorials/Intermediate/URDF/Using-URDF-with-Robot-State-Publisher-cpp.rst Co-authored-by: Christophe Bedard <[email protected]> Signed-off-by: Demonmasterlqx <[email protected]> * Update source/Tutorials/Intermediate/URDF/Using-URDF-with-Robot-State-Publisher-cpp.rst Co-authored-by: Christophe Bedard <[email protected]> Signed-off-by: Demonmasterlqx <[email protected]> * codespell Signed-off-by: Alejandro Hernandez Cordero <[email protected]> * Title underline too short Signed-off-by: Alejandro Hernandez Cordero <[email protected]> * make tutorials visible Signed-off-by: Alejandro Hernandez Cordero <[email protected]> --------- Signed-off-by: Demonmasterlqx <[email protected]> Signed-off-by: Katherine Scott <[email protected]> Signed-off-by: Alejandro Hernandez Cordero <[email protected]> Co-authored-by: kscottz <[email protected]> Co-authored-by: Christophe Bedard <[email protected]> Co-authored-by: Alejandro Hernandez Cordero <[email protected]> (cherry picked from commit 228a7b2) Co-authored-by: Demonmasterlqx <[email protected]>
fujitatomoya
added a commit
that referenced
this pull request
Feb 24, 2025
* add cpp version for urdf_tutorial (#4926) * Update Debugging-Tf2-Problems.rst some command to launch debug demo is wrong and correct it Signed-off-by: Demonmasterlqx <[email protected]> * Update Debugging-Tf2-Problems.rst Signed-off-by: Demonmasterlqx <[email protected]> * Rename Using-URDF-with-Robot-State-Publisher.rst to Using-URDF-with-Robot-State-Publisher-py.rst change name Signed-off-by: Demonmasterlqx <[email protected]> * Create Using-URDF-with-Robot-State-Publisher-cpp.rst add cpp version Signed-off-by: Demonmasterlqx <[email protected]> * Update Using-URDF-with-Robot-State-Publisher-cpp.rst add .. redirect-from:: Tutorials/URDF/Using-URDF-with-Robot-State-Publisher Signed-off-by: Demonmasterlqx <[email protected]> * Update Using-URDF-with-Robot-State-Publisher-cpp.rst Signed-off-by: Demonmasterlqx <[email protected]> * Update Using-URDF-with-Robot-State-Publisher-cpp.rst Polish my language Signed-off-by: Demonmasterlqx <[email protected]> * Update Using-URDF-with-Robot-State-Publisher-cpp.rst add code comment Signed-off-by: Demonmasterlqx <[email protected]> * Update Using-URDF-with-Robot-State-Publisher-cpp.rst fix format problems Signed-off-by: Demonmasterlqx <[email protected]> * White space help. * Update source/Tutorials/Intermediate/URDF/Using-URDF-with-Robot-State-Publisher-cpp.rst Signed-off-by: Katherine Scott <[email protected]> * Update source/Tutorials/Intermediate/URDF/Using-URDF-with-Robot-State-Publisher-cpp.rst Signed-off-by: Katherine Scott <[email protected]> * Update source/Tutorials/Intermediate/URDF/Using-URDF-with-Robot-State-Publisher-cpp.rst Signed-off-by: Katherine Scott <[email protected]> * Update source/Tutorials/Intermediate/URDF/Using-URDF-with-Robot-State-Publisher-cpp.rst Signed-off-by: Katherine Scott <[email protected]> * Update source/Tutorials/Intermediate/URDF/Using-URDF-with-Robot-State-Publisher-cpp.rst Signed-off-by: Katherine Scott <[email protected]> * Update source/Tutorials/Intermediate/URDF/Using-URDF-with-Robot-State-Publisher-cpp.rst Signed-off-by: Katherine Scott <[email protected]> * Update source/Tutorials/Intermediate/URDF/Using-URDF-with-Robot-State-Publisher-cpp.rst Co-authored-by: Christophe Bedard <[email protected]> Signed-off-by: Demonmasterlqx <[email protected]> * Update source/Tutorials/Intermediate/URDF/Using-URDF-with-Robot-State-Publisher-cpp.rst Co-authored-by: Christophe Bedard <[email protected]> Signed-off-by: Demonmasterlqx <[email protected]> * codespell Signed-off-by: Alejandro Hernandez Cordero <[email protected]> * Title underline too short Signed-off-by: Alejandro Hernandez Cordero <[email protected]> * make tutorials visible Signed-off-by: Alejandro Hernandez Cordero <[email protected]> --------- Signed-off-by: Demonmasterlqx <[email protected]> Signed-off-by: Katherine Scott <[email protected]> Signed-off-by: Alejandro Hernandez Cordero <[email protected]> Co-authored-by: kscottz <[email protected]> Co-authored-by: Christophe Bedard <[email protected]> Co-authored-by: Alejandro Hernandez Cordero <[email protected]> (cherry picked from commit 228a7b2) # Conflicts: # source/Tutorials/Intermediate/URDF/URDF-Main.rst * resolve conflict. Signed-off-by: Tomoya.Fujita <[email protected]> --------- Signed-off-by: Tomoya.Fujita <[email protected]> Co-authored-by: Demonmasterlqx <[email protected]> Co-authored-by: Tomoya.Fujita <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.