Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix smart quotes #5030

Merged
merged 2 commits into from
Feb 18, 2025
Merged

Fix smart quotes #5030

merged 2 commits into from
Feb 18, 2025

Conversation

DLu
Copy link
Contributor

@DLu DLu commented Feb 14, 2025

Replace unicode quotation marks and apostrophes with the standard equivalents.

This process should be automated in the future. See #4998 (comment) and https://github.com/sirosen/texthooks

@christophebedard christophebedard added the backport-all backport at reviewers discretion; from rolling to all versions label Feb 14, 2025
@christophebedard
Copy link
Member

There's a conflict since I merged the other PR.

Copy link
Collaborator

@fujitatomoya fujitatomoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just one comment for change log files, everything else looks good to me.

@DLu DLu mentioned this pull request Feb 18, 2025
Copy link
Member

@christophebedard christophebedard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fixes.

@christophebedard
Copy link
Member

I'll take care of backporting and fixing potential merge conflicts.

@christophebedard christophebedard merged commit ecdc45f into ros2:rolling Feb 18, 2025
5 checks passed
mergify bot pushed a commit that referenced this pull request Feb 18, 2025
(cherry picked from commit ecdc45f)

# Conflicts:
#	source/Related-Projects/Visualizing-ROS-2-Data-With-Foxglove.rst
mergify bot pushed a commit that referenced this pull request Feb 18, 2025
(cherry picked from commit ecdc45f)

# Conflicts:
#	source/Related-Projects/Visualizing-ROS-2-Data-With-Foxglove.rst
#	source/Tutorials/Demos/Quality-of-Service.rst
#	source/Tutorials/Intermediate/Monitoring-For-Parameter-Changes-Python.rst
christophebedard added a commit that referenced this pull request Feb 18, 2025
* Fix smart quotes (#5030)

(cherry picked from commit ecdc45f)

Signed-off-by: Christophe Bedard <[email protected]>
Co-authored-by: David V. Lu!! <[email protected]>
Co-authored-by: Christophe Bedard <[email protected]>
christophebedard added a commit that referenced this pull request Feb 18, 2025
* Fix smart quotes (#5030)

(cherry picked from commit ecdc45f)

Signed-off-by: Christophe Bedard <[email protected]>
Co-authored-by: David V. Lu!! <[email protected]>
Co-authored-by: Christophe Bedard <[email protected]>
@DLu DLu deleted the unicode_boo branch February 18, 2025 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-all backport at reviewers discretion; from rolling to all versions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants