-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix smart quotes #5030
Fix smart quotes #5030
Conversation
There's a conflict since I merged the other PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just one comment for change log files, everything else looks good to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fixes.
I'll take care of backporting and fixing potential merge conflicts. |
(cherry picked from commit ecdc45f) # Conflicts: # source/Related-Projects/Visualizing-ROS-2-Data-With-Foxglove.rst
(cherry picked from commit ecdc45f) # Conflicts: # source/Related-Projects/Visualizing-ROS-2-Data-With-Foxglove.rst # source/Tutorials/Demos/Quality-of-Service.rst # source/Tutorials/Intermediate/Monitoring-For-Parameter-Changes-Python.rst
* Fix smart quotes (#5030) (cherry picked from commit ecdc45f) Signed-off-by: Christophe Bedard <[email protected]> Co-authored-by: David V. Lu!! <[email protected]> Co-authored-by: Christophe Bedard <[email protected]>
* Fix smart quotes (#5030) (cherry picked from commit ecdc45f) Signed-off-by: Christophe Bedard <[email protected]> Co-authored-by: David V. Lu!! <[email protected]> Co-authored-by: Christophe Bedard <[email protected]>
Replace unicode quotation marks and apostrophes with the standard equivalents.
This process should be automated in the future. See #4998 (comment) and https://github.com/sirosen/texthooks