Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI - play verb metavar #1906

Open
wants to merge 2 commits into
base: rolling
Choose a base branch
from
Open

CLI - play verb metavar #1906

wants to merge 2 commits into from

Conversation

roncapat
Copy link
Contributor

Cosmetic - Better show --clock [HZ] than --clock [CLOCK] in argument list.

better show `--clock [HZ]` than `--clock [CLOCK]`

Signed-off-by: Patrick Roncagliolo <[email protected]>
Copy link
Contributor

@fujitatomoya fujitatomoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DCO is missing, can you also address that?

@@ -92,7 +92,8 @@ def add_arguments(self, parser, cli_name): # noqa: D102
'--clock', type=positive_float, nargs='?', const=40, default=0,
help='Publish to /clock at a specific frequency in Hz, to act as a ROS Time Source. '
'Value must be positive. Defaults to not publishing.'
'If specified, /clock topic in the bag file is excluded to publish.')
'If specified, /clock topic in the bag file is excluded to publish.',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about the following?

            '--clock', type=positive_float, metavar='Hz', nargs='?', const=40, default=0,
            help='Publish to /clock at a specific frequency in Hz, to act as a ROS Time Source. '
                 'Value must be positive. Defaults to not publishing.'
                 'If specified, /clock topic in the bag file is excluded to publish.')

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants