Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI - play verb metavar #1906

Open
wants to merge 2 commits into
base: rolling
Choose a base branch
from
Open

CLI - play verb metavar #1906

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4f9aadb
CLI - play verb metavar
roncapat Jan 30, 2025
4519e64
Update play.py
roncapat Jan 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion ros2bag/ros2bag/verb/play.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,8 @@ def add_arguments(self, parser, cli_name): # noqa: D102
'--clock', type=positive_float, nargs='?', const=40, default=0,
help='Publish to /clock at a specific frequency in Hz, to act as a ROS Time Source. '
'Value must be positive. Defaults to not publishing.'
'If specified, /clock topic in the bag file is excluded to publish.')
'If specified, /clock topic in the bag file is excluded to publish.',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about the following?

            '--clock', type=positive_float, metavar='Hz', nargs='?', const=40, default=0,
            help='Publish to /clock at a specific frequency in Hz, to act as a ROS Time Source. '
                 'Value must be positive. Defaults to not publishing.'
                 'If specified, /clock topic in the bag file is excluded to publish.')

metavar='HZ')
clock_args_group.add_argument(
'--clock-topics', type=str, default=[], nargs='+',
help='List of topics separated by spaces that will trigger a /clock update '
Expand Down
Loading