-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DEV-103519] Upgrade to Django 4.2. Switch from travis to GHA #66
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved with the caveat that the Django 4 tests are failing due to what looks like a migration step that needs to be taken
Co-authored-by: Ben Menesini <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm! Sorry if I led you down a rabbit hole with the cache; I didn't think it was going to be a PITA
setup.cfg
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How did we settle on these options?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not actually sure. I merged in @facundojmaero's PR here and he had changed a few things. I assume it was to either get it to lint with the newer linter version and/or due to the formatting changes he made
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh gotcha. Yeah like the max line length change, for example. Not a huge deal since its just linting.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would recommend you to migrate to ruff and deprecate all isort
, flake8
, pylint/black
etc...
But it is up-to-you, just ruff
is blazing fast and making what it should do without issues...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks ok to me, just a question on some of the config. I don't have the Travis config for reference
Co-authored-by: Ben Menesini <[email protected]>
Here is all we removed regarding Travis. I don't know if we've had a Github Travis integration for a long while |
What is the reason for this PR?
We are upgrading this library to support Django 4.2. As a result, we are updating the requirements to be Python>=3.8 and Django >=3.2
We no longer use travis to run our CI/CD tests. Our standard here at Rover is to use Github Actions. This switches the testing of different python versions over to GHA.
Validation
How will we know this is working?