Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DEV-103519] Upgrade to Django 4.2. Switch from travis to GHA #66
[DEV-103519] Upgrade to Django 4.2. Switch from travis to GHA #66
Changes from 13 commits
3f0b5ca
b76d42b
29bf9c7
19fbdb2
26d3109
2f6536f
389a8c7
ea1e596
b05a184
19d70e2
9e9702a
f9e8cfe
a0a9862
5ef0d93
dd3630c
6e48fac
5129b91
14d399c
140f36b
6ebc5cf
a9f5320
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
This file was deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How did we settle on these options?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not actually sure. I merged in @facundojmaero's PR here and he had changed a few things. I assume it was to either get it to lint with the newer linter version and/or due to the formatting changes he made
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh gotcha. Yeah like the max line length change, for example. Not a huge deal since its just linting.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would recommend you to migrate to ruff and deprecate all
isort
,flake8
,pylint/black
etc...But it is up-to-you, just
ruff
is blazing fast and making what it should do without issues...