-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(306,308,310): Sidebar and accordion updates #231
Conversation
This will still exhibit failures for the following reasons. ✅ 310-bslib-sidebar-dynamicNested sidebars on mobile don't account for the taller space requirements of the toggle. ✅ 308-sidebar-kitchen-sinkThe flakiness in this test seems to be a problem with how chromote/Chrome take screenshots. Here's a screen recording of the screenshot process for the first tab, slowed down to 1/16 speed. You can clearly see some re-layout happens and it's very likely the screenshot happens just before the layout settles. shinytest2-screenshot-reload-slow.movIt looks like shinytest2 defaults to AppDriver$new(
variant = platform_variant(),
name = "308-sidebar-kitchen-sink",
# ...
# Set a delay to screenshot after layout is settled
screenshot_args = list(delay = 0.25)
) |
I finally figured out 308 -- I disabled the sidebar transition during the portion of the tests where we need to screenshot the closed sidebar. Then we re-enable the transition by removing the CSS that disabled it, before toggling the sidebar and screenshotting it in the open state. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cpsievert I've fixed the sidebar position, but it looks like theres a bug here that could be 1) a selectize issue; 2) an accordion issue; or 3) a bug in the test app. I poked at it a bit but didn't find an easy answer. (Note I also tried with the latest selectize fixes in shiny PR 3923.)
Minimizes transitions in sidebar by setting
It turns out we need a little transition time or the final part of the sidebar state transition lifecycle doesn't happen.
TODO