-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(306,308,310): Sidebar and accordion updates #231
Merged
Merged
Changes from all commits
Commits
Show all changes
25 commits
Select commit
Hold shift + click to select a range
e8ec836
fix: Disable transitions in sidebar tests with screenshots
gadenbuie d8893ac
chore: Need at least a small amount of transition time
gadenbuie a76aec1
chore: Avoid warning about re-used inputId
gadenbuie abc1ef3
tests(310): Update snapshots
gadenbuie c1db883
tests(308): Update snaps
gadenbuie bd98187
tests(308): Screenshot after a delay
gadenbuie ebd1562
tests(308): Try longer delay
gadenbuie 528680e
tests(308): Temporarily disable sidebar transition
gadenbuie fb14d40
tests(308): Update snaps for fixed test
gadenbuie 9ce15c6
tests(310): Update snaps with sidebar padding-top on mobile fix
gadenbuie dc18512
chore(308): Rename test file
gadenbuie 58c3b75
tests(308): New snaps
gadenbuie 4081ca9
test(306): Rename test file and snapshots
gadenbuie 46f7307
tests(306): Fix snapshot timing
gadenbuie b128f3b
tests(308): Use latest chromote features
gadenbuie b4f702c
tests(306): Update for latest chromote
gadenbuie d906e10
test(310): Use latest chromote
gadenbuie e8800db
Generate apps deps (GitHub Actions)
gadenbuie 4b2b3f2
test(306): Update snaps for all (using mac 4.3 snaps)
gadenbuie 4d94f30
tests(308): Accept new snaps
gadenbuie 9d0a0ff
tests(310): new snaps
gadenbuie c0d6c65
Merged origin/main into sidebar/padding-transition
gadenbuie af84fd2
chore(deps): Use dev chromote
gadenbuie a60c49c
`devtools::build_readme()` (GitHub Actions)
gadenbuie 9e2bcfe
tests: accept update snaps
gadenbuie File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Empty file.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file added
BIN
+85.2 KB
...sts/testthat/_snaps/linux-3.6/306-accordion-add-remove/accordion-select-001.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+49.3 KB
...sts/testthat/_snaps/linux-3.6/306-accordion-add-remove/accordion-select-002.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+82.2 KB
...sts/testthat/_snaps/linux-3.6/306-accordion-add-remove/accordion-select-003.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+42 KB
...sts/testthat/_snaps/linux-3.6/306-accordion-add-remove/accordion-select-004.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file removed
BIN
-85.4 KB
...-add-remove/tests/testthat/_snaps/linux-3.6/shinytest2/accordion-select-001.png
Binary file not shown.
Binary file removed
BIN
-51.1 KB
...-add-remove/tests/testthat/_snaps/linux-3.6/shinytest2/accordion-select-002.png
Binary file not shown.
Binary file removed
BIN
-81.2 KB
...-add-remove/tests/testthat/_snaps/linux-3.6/shinytest2/accordion-select-003.png
Binary file not shown.
Binary file removed
BIN
-42.7 KB
...-add-remove/tests/testthat/_snaps/linux-3.6/shinytest2/accordion-select-004.png
Binary file not shown.
Binary file added
BIN
+72.3 KB
...sts/testthat/_snaps/linux-4.0/306-accordion-add-remove/accordion-select-001.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+41 KB
...sts/testthat/_snaps/linux-4.0/306-accordion-add-remove/accordion-select-002.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+70.5 KB
...sts/testthat/_snaps/linux-4.0/306-accordion-add-remove/accordion-select-003.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+35.3 KB
...sts/testthat/_snaps/linux-4.0/306-accordion-add-remove/accordion-select-004.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file removed
BIN
-71.8 KB
...-add-remove/tests/testthat/_snaps/linux-4.0/shinytest2/accordion-select-001.png
Binary file not shown.
Binary file removed
BIN
-40.9 KB
...-add-remove/tests/testthat/_snaps/linux-4.0/shinytest2/accordion-select-002.png
Binary file not shown.
Binary file removed
BIN
-70 KB
...-add-remove/tests/testthat/_snaps/linux-4.0/shinytest2/accordion-select-003.png
Binary file not shown.
Binary file removed
BIN
-35.2 KB
...-add-remove/tests/testthat/_snaps/linux-4.0/shinytest2/accordion-select-004.png
Binary file not shown.
Binary file added
BIN
+72.3 KB
...sts/testthat/_snaps/linux-4.1/306-accordion-add-remove/accordion-select-001.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+41 KB
...sts/testthat/_snaps/linux-4.1/306-accordion-add-remove/accordion-select-002.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+70.5 KB
...sts/testthat/_snaps/linux-4.1/306-accordion-add-remove/accordion-select-003.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+35.3 KB
...sts/testthat/_snaps/linux-4.1/306-accordion-add-remove/accordion-select-004.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file removed
BIN
-71.8 KB
...-add-remove/tests/testthat/_snaps/linux-4.1/shinytest2/accordion-select-001.png
Binary file not shown.
Binary file removed
BIN
-40.9 KB
...-add-remove/tests/testthat/_snaps/linux-4.1/shinytest2/accordion-select-002.png
Binary file not shown.
Binary file removed
BIN
-70 KB
...-add-remove/tests/testthat/_snaps/linux-4.1/shinytest2/accordion-select-003.png
Binary file not shown.
Binary file removed
BIN
-35.2 KB
...-add-remove/tests/testthat/_snaps/linux-4.1/shinytest2/accordion-select-004.png
Binary file not shown.
Binary file added
BIN
+85.2 KB
...sts/testthat/_snaps/linux-4.2/306-accordion-add-remove/accordion-select-001.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+49.3 KB
...sts/testthat/_snaps/linux-4.2/306-accordion-add-remove/accordion-select-002.png
Oops, something went wrong.
Binary file added
BIN
+82.2 KB
...sts/testthat/_snaps/linux-4.2/306-accordion-add-remove/accordion-select-003.png
Oops, something went wrong.
Binary file added
BIN
+42 KB
...sts/testthat/_snaps/linux-4.2/306-accordion-add-remove/accordion-select-004.png
Oops, something went wrong.
Binary file removed
BIN
-71.8 KB
...-add-remove/tests/testthat/_snaps/linux-4.2/shinytest2/accordion-select-001.png
Diff not rendered.
Binary file removed
BIN
-40.9 KB
...-add-remove/tests/testthat/_snaps/linux-4.2/shinytest2/accordion-select-002.png
Diff not rendered.
Binary file removed
BIN
-70 KB
...-add-remove/tests/testthat/_snaps/linux-4.2/shinytest2/accordion-select-003.png
Diff not rendered.
Binary file removed
BIN
-35.2 KB
...-add-remove/tests/testthat/_snaps/linux-4.2/shinytest2/accordion-select-004.png
Diff not rendered.
Binary file added
BIN
+72.3 KB
...sts/testthat/_snaps/linux-4.3/306-accordion-add-remove/accordion-select-001.png
Oops, something went wrong.
Binary file added
BIN
+41 KB
...sts/testthat/_snaps/linux-4.3/306-accordion-add-remove/accordion-select-002.png
Oops, something went wrong.
Binary file added
BIN
+70.5 KB
...sts/testthat/_snaps/linux-4.3/306-accordion-add-remove/accordion-select-003.png
Oops, something went wrong.
Binary file added
BIN
+35.3 KB
...sts/testthat/_snaps/linux-4.3/306-accordion-add-remove/accordion-select-004.png
Oops, something went wrong.
Binary file removed
BIN
-71.8 KB
...-add-remove/tests/testthat/_snaps/linux-4.3/shinytest2/accordion-select-001.png
Diff not rendered.
Binary file removed
BIN
-40.9 KB
...-add-remove/tests/testthat/_snaps/linux-4.3/shinytest2/accordion-select-002.png
Diff not rendered.
Binary file removed
BIN
-70 KB
...-add-remove/tests/testthat/_snaps/linux-4.3/shinytest2/accordion-select-003.png
Diff not rendered.
Binary file removed
BIN
-35.2 KB
...-add-remove/tests/testthat/_snaps/linux-4.3/shinytest2/accordion-select-004.png
Diff not rendered.
Binary file added
BIN
+85.2 KB
...tests/testthat/_snaps/mac-3.6/306-accordion-add-remove/accordion-select-001.png
Oops, something went wrong.
Binary file added
BIN
+49.3 KB
...tests/testthat/_snaps/mac-3.6/306-accordion-add-remove/accordion-select-002.png
Oops, something went wrong.
Binary file added
BIN
+82.2 KB
...tests/testthat/_snaps/mac-3.6/306-accordion-add-remove/accordion-select-003.png
Oops, something went wrong.
Binary file added
BIN
+42 KB
...tests/testthat/_snaps/mac-3.6/306-accordion-add-remove/accordion-select-004.png
Oops, something went wrong.
Binary file removed
BIN
-84.4 KB
...on-add-remove/tests/testthat/_snaps/mac-3.6/shinytest2/accordion-select-001.png
Diff not rendered.
Binary file removed
BIN
-49.5 KB
...on-add-remove/tests/testthat/_snaps/mac-3.6/shinytest2/accordion-select-002.png
Diff not rendered.
Binary file removed
BIN
-81.1 KB
...on-add-remove/tests/testthat/_snaps/mac-3.6/shinytest2/accordion-select-003.png
Diff not rendered.
Binary file removed
BIN
-41.9 KB
...on-add-remove/tests/testthat/_snaps/mac-3.6/shinytest2/accordion-select-004.png
Diff not rendered.
Binary file added
BIN
+85.2 KB
...tests/testthat/_snaps/mac-4.0/306-accordion-add-remove/accordion-select-001.png
Oops, something went wrong.
Binary file added
BIN
+49.3 KB
...tests/testthat/_snaps/mac-4.0/306-accordion-add-remove/accordion-select-002.png
Oops, something went wrong.
Binary file added
BIN
+82.2 KB
...tests/testthat/_snaps/mac-4.0/306-accordion-add-remove/accordion-select-003.png
Oops, something went wrong.
Binary file added
BIN
+41.9 KB
...tests/testthat/_snaps/mac-4.0/306-accordion-add-remove/accordion-select-004.png
Oops, something went wrong.
Binary file removed
BIN
-85.1 KB
...on-add-remove/tests/testthat/_snaps/mac-4.0/shinytest2/accordion-select-001.png
Diff not rendered.
Binary file removed
BIN
-49.5 KB
...on-add-remove/tests/testthat/_snaps/mac-4.0/shinytest2/accordion-select-002.png
Diff not rendered.
Binary file removed
BIN
-81.1 KB
...on-add-remove/tests/testthat/_snaps/mac-4.0/shinytest2/accordion-select-003.png
Diff not rendered.
Binary file removed
BIN
-41.9 KB
...on-add-remove/tests/testthat/_snaps/mac-4.0/shinytest2/accordion-select-004.png
Diff not rendered.
Binary file added
BIN
+85.2 KB
...tests/testthat/_snaps/mac-4.1/306-accordion-add-remove/accordion-select-001.png
Oops, something went wrong.
Binary file added
BIN
+49.3 KB
...tests/testthat/_snaps/mac-4.1/306-accordion-add-remove/accordion-select-002.png
Oops, something went wrong.
Binary file added
BIN
+82.2 KB
...tests/testthat/_snaps/mac-4.1/306-accordion-add-remove/accordion-select-003.png
Oops, something went wrong.
Binary file added
BIN
+41.9 KB
...tests/testthat/_snaps/mac-4.1/306-accordion-add-remove/accordion-select-004.png
Oops, something went wrong.
Binary file removed
BIN
-84.3 KB
...on-add-remove/tests/testthat/_snaps/mac-4.1/shinytest2/accordion-select-001.png
Diff not rendered.
Binary file removed
BIN
-49.3 KB
...on-add-remove/tests/testthat/_snaps/mac-4.1/shinytest2/accordion-select-002.png
Diff not rendered.
Binary file removed
BIN
-80.7 KB
...on-add-remove/tests/testthat/_snaps/mac-4.1/shinytest2/accordion-select-003.png
Diff not rendered.
Binary file removed
BIN
-41.7 KB
...on-add-remove/tests/testthat/_snaps/mac-4.1/shinytest2/accordion-select-004.png
Diff not rendered.
Binary file added
BIN
+85.2 KB
...tests/testthat/_snaps/mac-4.2/306-accordion-add-remove/accordion-select-001.png
Oops, something went wrong.
Binary file added
BIN
+49.3 KB
...tests/testthat/_snaps/mac-4.2/306-accordion-add-remove/accordion-select-002.png
Oops, something went wrong.
Binary file added
BIN
+82.2 KB
...tests/testthat/_snaps/mac-4.2/306-accordion-add-remove/accordion-select-003.png
Oops, something went wrong.
Binary file added
BIN
+41.9 KB
...tests/testthat/_snaps/mac-4.2/306-accordion-add-remove/accordion-select-004.png
Oops, something went wrong.
Binary file removed
BIN
-85.1 KB
...on-add-remove/tests/testthat/_snaps/mac-4.2/shinytest2/accordion-select-001.png
Diff not rendered.
Binary file removed
BIN
-49.5 KB
...on-add-remove/tests/testthat/_snaps/mac-4.2/shinytest2/accordion-select-002.png
Diff not rendered.
Binary file removed
BIN
-81.1 KB
...on-add-remove/tests/testthat/_snaps/mac-4.2/shinytest2/accordion-select-003.png
Diff not rendered.
Binary file removed
BIN
-41.9 KB
...on-add-remove/tests/testthat/_snaps/mac-4.2/shinytest2/accordion-select-004.png
Diff not rendered.
Binary file added
BIN
+85.2 KB
...tests/testthat/_snaps/mac-4.3/306-accordion-add-remove/accordion-select-001.png
Oops, something went wrong.
Binary file added
BIN
+49.3 KB
...tests/testthat/_snaps/mac-4.3/306-accordion-add-remove/accordion-select-002.png
Oops, something went wrong.
Binary file added
BIN
+82.2 KB
...tests/testthat/_snaps/mac-4.3/306-accordion-add-remove/accordion-select-003.png
Oops, something went wrong.
Binary file added
BIN
+41.9 KB
...tests/testthat/_snaps/mac-4.3/306-accordion-add-remove/accordion-select-004.png
Oops, something went wrong.
Binary file removed
BIN
-84.3 KB
...on-add-remove/tests/testthat/_snaps/mac-4.3/shinytest2/accordion-select-001.png
Diff not rendered.
Binary file removed
BIN
-49.5 KB
...on-add-remove/tests/testthat/_snaps/mac-4.3/shinytest2/accordion-select-002.png
Diff not rendered.
Binary file removed
BIN
-80.7 KB
...on-add-remove/tests/testthat/_snaps/mac-4.3/shinytest2/accordion-select-003.png
Diff not rendered.
Binary file removed
BIN
-41.7 KB
...on-add-remove/tests/testthat/_snaps/mac-4.3/shinytest2/accordion-select-004.png
Diff not rendered.
Binary file added
BIN
+85.2 KB
...s/testthat/_snaps/windows-3.6/306-accordion-add-remove/accordion-select-001.png
Oops, something went wrong.
Binary file added
BIN
+49.3 KB
...s/testthat/_snaps/windows-3.6/306-accordion-add-remove/accordion-select-002.png
Oops, something went wrong.
Binary file added
BIN
+82.2 KB
...s/testthat/_snaps/windows-3.6/306-accordion-add-remove/accordion-select-003.png
Oops, something went wrong.
Binary file added
BIN
+42 KB
...s/testthat/_snaps/windows-3.6/306-accordion-add-remove/accordion-select-004.png
Oops, something went wrong.
Binary file removed
BIN
-49.4 KB
...dd-remove/tests/testthat/_snaps/windows-3.6/shinytest2/accordion-select-001.png
Diff not rendered.
Binary file removed
BIN
-30.7 KB
...dd-remove/tests/testthat/_snaps/windows-3.6/shinytest2/accordion-select-002.png
Diff not rendered.
Binary file removed
BIN
-48.5 KB
...dd-remove/tests/testthat/_snaps/windows-3.6/shinytest2/accordion-select-003.png
Diff not rendered.
Binary file removed
BIN
-27.4 KB
...dd-remove/tests/testthat/_snaps/windows-3.6/shinytest2/accordion-select-004.png
Diff not rendered.
Binary file added
BIN
+85.2 KB
...s/testthat/_snaps/windows-4.0/306-accordion-add-remove/accordion-select-001.png
Oops, something went wrong.
Binary file added
BIN
+49.3 KB
...s/testthat/_snaps/windows-4.0/306-accordion-add-remove/accordion-select-002.png
Oops, something went wrong.
Binary file added
BIN
+82.2 KB
...s/testthat/_snaps/windows-4.0/306-accordion-add-remove/accordion-select-003.png
Oops, something went wrong.
Binary file added
BIN
+42 KB
...s/testthat/_snaps/windows-4.0/306-accordion-add-remove/accordion-select-004.png
Oops, something went wrong.
Binary file removed
BIN
-49.4 KB
...dd-remove/tests/testthat/_snaps/windows-4.0/shinytest2/accordion-select-001.png
Diff not rendered.
Binary file removed
BIN
-30.7 KB
...dd-remove/tests/testthat/_snaps/windows-4.0/shinytest2/accordion-select-002.png
Diff not rendered.
Binary file removed
BIN
-48.5 KB
...dd-remove/tests/testthat/_snaps/windows-4.0/shinytest2/accordion-select-003.png
Diff not rendered.
Binary file removed
BIN
-27.4 KB
...dd-remove/tests/testthat/_snaps/windows-4.0/shinytest2/accordion-select-004.png
Diff not rendered.
Binary file added
BIN
+85.2 KB
...s/testthat/_snaps/windows-4.1/306-accordion-add-remove/accordion-select-001.png
Oops, something went wrong.
Binary file added
BIN
+49.3 KB
...s/testthat/_snaps/windows-4.1/306-accordion-add-remove/accordion-select-002.png
Oops, something went wrong.
Binary file added
BIN
+82.2 KB
...s/testthat/_snaps/windows-4.1/306-accordion-add-remove/accordion-select-003.png
Oops, something went wrong.
Binary file added
BIN
+42 KB
...s/testthat/_snaps/windows-4.1/306-accordion-add-remove/accordion-select-004.png
Oops, something went wrong.
Binary file removed
BIN
-76.6 KB
...dd-remove/tests/testthat/_snaps/windows-4.1/shinytest2/accordion-select-001.png
Diff not rendered.
Binary file removed
BIN
-45 KB
...dd-remove/tests/testthat/_snaps/windows-4.1/shinytest2/accordion-select-002.png
Diff not rendered.
Binary file removed
BIN
-73.4 KB
...dd-remove/tests/testthat/_snaps/windows-4.1/shinytest2/accordion-select-003.png
Diff not rendered.
Binary file removed
BIN
-37.4 KB
...dd-remove/tests/testthat/_snaps/windows-4.1/shinytest2/accordion-select-004.png
Diff not rendered.
Binary file added
BIN
+76.8 KB
...s/testthat/_snaps/windows-4.2/306-accordion-add-remove/accordion-select-001.png
Oops, something went wrong.
Binary file added
BIN
+44.8 KB
...s/testthat/_snaps/windows-4.2/306-accordion-add-remove/accordion-select-002.png
Oops, something went wrong.
Binary file added
BIN
+73.7 KB
...s/testthat/_snaps/windows-4.2/306-accordion-add-remove/accordion-select-003.png
Oops, something went wrong.
Binary file added
BIN
+37.4 KB
...s/testthat/_snaps/windows-4.2/306-accordion-add-remove/accordion-select-004.png
Oops, something went wrong.
Binary file removed
BIN
-76.6 KB
...dd-remove/tests/testthat/_snaps/windows-4.2/shinytest2/accordion-select-001.png
Diff not rendered.
Binary file removed
BIN
-45 KB
...dd-remove/tests/testthat/_snaps/windows-4.2/shinytest2/accordion-select-002.png
Diff not rendered.
Binary file removed
BIN
-73.4 KB
...dd-remove/tests/testthat/_snaps/windows-4.2/shinytest2/accordion-select-003.png
Diff not rendered.
Binary file removed
BIN
-37.4 KB
...dd-remove/tests/testthat/_snaps/windows-4.2/shinytest2/accordion-select-004.png
Diff not rendered.
Binary file added
BIN
+76.8 KB
...s/testthat/_snaps/windows-4.3/306-accordion-add-remove/accordion-select-001.png
Oops, something went wrong.
Binary file added
BIN
+44.8 KB
...s/testthat/_snaps/windows-4.3/306-accordion-add-remove/accordion-select-002.png
Oops, something went wrong.
Binary file added
BIN
+73.7 KB
...s/testthat/_snaps/windows-4.3/306-accordion-add-remove/accordion-select-003.png
Oops, something went wrong.
Binary file added
BIN
+37.4 KB
...s/testthat/_snaps/windows-4.3/306-accordion-add-remove/accordion-select-004.png
Oops, something went wrong.
Binary file removed
BIN
-76.4 KB
...dd-remove/tests/testthat/_snaps/windows-4.3/shinytest2/accordion-select-001.png
Diff not rendered.
Binary file removed
BIN
-45 KB
...dd-remove/tests/testthat/_snaps/windows-4.3/shinytest2/accordion-select-002.png
Diff not rendered.
Binary file removed
BIN
-73.4 KB
...dd-remove/tests/testthat/_snaps/windows-4.3/shinytest2/accordion-select-003.png
Diff not rendered.
Binary file removed
BIN
-37.4 KB
...dd-remove/tests/testthat/_snaps/windows-4.3/shinytest2/accordion-select-004.png
Diff not rendered.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file added
BIN
+52.3 KB
...stthat/_snaps/mac-4.3/308-sidebar-kitchen-sink/308-sidebar-kitchen-sink-001.png
Oops, something went wrong.
Binary file added
BIN
+117 KB
...stthat/_snaps/mac-4.3/308-sidebar-kitchen-sink/308-sidebar-kitchen-sink-002.png
Oops, something went wrong.
Binary file added
BIN
+195 KB
...stthat/_snaps/mac-4.3/308-sidebar-kitchen-sink/308-sidebar-kitchen-sink-003.png
Oops, something went wrong.
Binary file added
BIN
+99 KB
...stthat/_snaps/mac-4.3/308-sidebar-kitchen-sink/308-sidebar-kitchen-sink-004.png
Oops, something went wrong.
Binary file added
BIN
+130 KB
...stthat/_snaps/mac-4.3/308-sidebar-kitchen-sink/308-sidebar-kitchen-sink-005.png
Oops, something went wrong.
Binary file added
BIN
+135 KB
...stthat/_snaps/mac-4.3/308-sidebar-kitchen-sink/308-sidebar-kitchen-sink-006.png
Oops, something went wrong.
Binary file removed
BIN
-50.8 KB
...-sink/tests/testthat/_snaps/mac-4.3/shinytest2/308-sidebar-kitchen-sink-001.png
Diff not rendered.
Binary file removed
BIN
-112 KB
...-sink/tests/testthat/_snaps/mac-4.3/shinytest2/308-sidebar-kitchen-sink-002.png
Diff not rendered.
Binary file removed
BIN
-188 KB
...-sink/tests/testthat/_snaps/mac-4.3/shinytest2/308-sidebar-kitchen-sink-003.png
Diff not rendered.
Binary file removed
BIN
-97.2 KB
...-sink/tests/testthat/_snaps/mac-4.3/shinytest2/308-sidebar-kitchen-sink-004.png
Diff not rendered.
Binary file removed
BIN
-128 KB
...-sink/tests/testthat/_snaps/mac-4.3/shinytest2/308-sidebar-kitchen-sink-005.png
Diff not rendered.
Binary file removed
BIN
-133 KB
...-sink/tests/testthat/_snaps/mac-4.3/shinytest2/308-sidebar-kitchen-sink-006.png
Diff not rendered.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file modified
BIN
-396 Bytes
(98%)
...that/_snaps/mac-4.3/310-bslib-sidebar-dynamic/310-bslib-sidebar-dynamic-002.png
Oops, something went wrong.
Binary file modified
BIN
+58 Bytes
(100%)
...that/_snaps/mac-4.3/310-bslib-sidebar-dynamic/310-bslib-sidebar-dynamic-004.png
Oops, something went wrong.
Binary file modified
BIN
+91 Bytes
(100%)
...that/_snaps/mac-4.3/310-bslib-sidebar-dynamic/310-bslib-sidebar-dynamic-006.png
Oops, something went wrong.
Binary file modified
BIN
+13 Bytes
(100%)
...that/_snaps/mac-4.3/310-bslib-sidebar-dynamic/310-bslib-sidebar-dynamic-008.png
Oops, something went wrong.
Binary file modified
BIN
+23 Bytes
(100%)
...that/_snaps/mac-4.3/310-bslib-sidebar-dynamic/310-bslib-sidebar-dynamic-010.png
Oops, something went wrong.
Binary file modified
BIN
+69 Bytes
(100%)
...that/_snaps/mac-4.3/310-bslib-sidebar-dynamic/310-bslib-sidebar-dynamic-012.png
Oops, something went wrong.
Binary file modified
BIN
+73 Bytes
(100%)
...that/_snaps/mac-4.3/310-bslib-sidebar-dynamic/310-bslib-sidebar-dynamic-014.png
Oops, something went wrong.
Binary file modified
BIN
+84 Bytes
(100%)
...that/_snaps/mac-4.3/310-bslib-sidebar-dynamic/310-bslib-sidebar-dynamic-015.png
Oops, something went wrong.
Binary file modified
BIN
+80 Bytes
(100%)
...that/_snaps/mac-4.3/310-bslib-sidebar-dynamic/310-bslib-sidebar-dynamic-017.png
Oops, something went wrong.
Binary file modified
BIN
+84 Bytes
(100%)
...that/_snaps/mac-4.3/310-bslib-sidebar-dynamic/310-bslib-sidebar-dynamic-019.png
Oops, something went wrong.
Binary file modified
BIN
+78 Bytes
(100%)
...that/_snaps/mac-4.3/310-bslib-sidebar-dynamic/310-bslib-sidebar-dynamic-021.png
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cpsievert I've fixed the sidebar position, but it looks like theres a bug here that could be 1) a selectize issue; 2) an accordion issue; or 3) a bug in the test app. I poked at it a bit but didn't find an easy answer. (Note I also tried with the latest selectize fixes in shiny PR 3923.)