Skip to content

Conversation

@mensfeld
Copy link
Collaborator

@mensfeld mensfeld commented Nov 2, 2025

Summary by CodeRabbit

  • Breaking Changes

    • Removed support for Rails 7.0 and 7.1. Users on older Rails versions should upgrade to Rails 7.2 or later, or remain on Shoryuken 6.x.
  • New Features

    • Added support for Rails 8.1 with corresponding test coverage.
  • Chores

    • Updated CI/CD test matrix to verify compatibility with Rails 7.2, 8.0, and 8.1.

@mensfeld mensfeld requested a review from Copilot November 2, 2025 09:59
@mensfeld mensfeld self-assigned this Nov 2, 2025
@mensfeld mensfeld added the rails label Nov 2, 2025
@coderabbitai
Copy link

coderabbitai bot commented Nov 2, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

The PR updates Rails version support by removing end-of-life versions (7.0 and 7.1), retaining Rails 7.2 and 8.0 support, and adding Rails 8.1. It updates the GitHub Actions CI matrix, Appraisal gemfiles, and documentation to reflect the new supported versions with aligned Ruby versions (3.2, 3.3, and 3.4 respectively).

Changes

Cohort / File(s) Summary
CI & Appraisal Configuration
.github/workflows/specs.yml, Appraisals
Updated Rails specs matrix: removed 7.0/7.1 entries, adjusted Ruby versions for 7.2 (3.2) and 8.0 (3.3), added 8.1 entry with Ruby 3.4; synced Appraisals block with Rails matrix changes.
Gemfiles: Removed
gemfiles/rails_7_0.gemfile, gemfiles/rails_7_1.gemfile
Deleted Appraisal gemfiles for Rails 7.0 and 7.1.
Gemfiles: Updated
gemfiles/rails_7_2.gemfile, gemfiles/rails_8_0.gemfile
Normalized quote style from single to double quotes across gem declarations and paths; no semantic changes.
Gemfiles: Added
gemfiles/rails_8_1.gemfile
Created new Appraisal gemfile for Rails 8.1 with ActiveJob ~> 8.1, httparty, multi_xml, simplecov, warning, and development dependencies.
Documentation
CHANGELOG.md
Added breaking change entry documenting removal of Rails 7.0 and 7.1 support; listed supported versions (7.2, 8.0, 8.1) and advised users on older Rails to upgrade or remain on Shoryuken 6.x.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

  • Verify Ruby version alignments are correct for each Rails version (7.2→3.2, 8.0→3.3, 8.1→3.4)
  • Confirm gemfiles/rails_8_1.gemfile dependencies match the Rails 8.1 ecosystem requirements
  • Check for any remaining references to Rails 7.0/7.1 in other configuration files or documentation not shown in this diff

Possibly related PRs

Suggested reviewers

  • phstc

Poem

🐰 Rails march forward, the old must retire,
Seven-point-oh fades like forest fire,
Eight-point-one joins the tested tier,
Ruby versions aligned, the CI runs clear,
Shoryuken hops to the future near! 🚀

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch drop-rails-7-1-add-rails8-1

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between dafabc5 and 69acbdc.

📒 Files selected for processing (8)
  • .github/workflows/specs.yml (1 hunks)
  • Appraisals (1 hunks)
  • CHANGELOG.md (1 hunks)
  • gemfiles/rails_7_0.gemfile (0 hunks)
  • gemfiles/rails_7_1.gemfile (0 hunks)
  • gemfiles/rails_7_2.gemfile (1 hunks)
  • gemfiles/rails_8_0.gemfile (1 hunks)
  • gemfiles/rails_8_1.gemfile (1 hunks)

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates Rails version support by removing EOL versions (7.0 and 7.1) and adding support for Rails 8.1. The changes standardize gemfile quote styles and update the test matrix accordingly.

  • Remove Rails 7.0 and 7.1 support (EOL versions)
  • Add Rails 8.1 support in Appraisals and gemfiles
  • Standardize quote style in gemfiles from single to double quotes

Reviewed Changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.

Show a summary per file
File Description
Appraisals Removes Rails 7.0 and 7.1 appraisals, adds Rails 8.1 appraisal
gemfiles/rails_8_1.gemfile Adds new gemfile for Rails 8.1 testing
gemfiles/rails_8_0.gemfile Updates quote style from single to double quotes
gemfiles/rails_7_2.gemfile Updates quote style from single to double quotes
gemfiles/rails_7_1.gemfile Removes gemfile for EOL Rails 7.1
gemfiles/rails_7_0.gemfile Removes gemfile for EOL Rails 7.0
CHANGELOG.md Documents breaking change and supported Rails versions

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@mensfeld mensfeld merged commit 3bfac4d into main Nov 2, 2025
17 of 18 checks passed
@mensfeld mensfeld deleted the drop-rails-7-1-add-rails8-1 branch November 2, 2025 10:03
@coderabbitai coderabbitai bot mentioned this pull request Dec 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants