-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: onboard new destination ninetailed #1617
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #1617 +/- ##
========================================
Coverage 52.32% 52.32%
========================================
Files 581 586 +5
Lines 16592 16642 +50
Branches 3231 3225 -6
========================================
+ Hits 8681 8708 +27
- Misses 6463 6523 +60
+ Partials 1448 1411 -37 ☔ View full report in Codecov by Sentry. |
size-limit report 📦
|
packages/analytics-js-integrations/src/integrations/Ninetailed/browser.js
Show resolved
Hide resolved
packages/analytics-js-integrations/src/integrations/Ninetailed/browser.js
Outdated
Show resolved
Hide resolved
packages/analytics-js-integrations/__tests__/integrations/Ninetailed/browser.test.js
Outdated
Show resolved
Hide resolved
packages/analytics-js-integrations/__tests__/integrations/Ninetailed/browser.test.js
Outdated
Show resolved
Hide resolved
packages/analytics-js-integrations/__tests__/integrations/Ninetailed/browser.test.js
Show resolved
Hide resolved
8525526
to
b148925
Compare
packages/analytics-js-integrations/__tests__/integrations/Ninetailed/browser.test.js
Outdated
Show resolved
Hide resolved
packages/analytics-js-integrations/__tests__/integrations/Ninetailed/browser.test.js
Show resolved
Hide resolved
packages/analytics-js-integrations/__tests__/integrations/Ninetailed/browser.test.js
Show resolved
Hide resolved
packages/analytics-js-integrations/__tests__/integrations/Ninetailed/browser.test.js
Outdated
Show resolved
Hide resolved
packages/analytics-js-integrations/__tests__/integrations/Ninetailed/browser.test.js
Outdated
Show resolved
Hide resolved
packages/analytics-js-integrations/src/integrations/Ninetailed/browser.js
Outdated
Show resolved
Hide resolved
packages/analytics-js-integrations/src/integrations/Ninetailed/sample-app/README.md
Show resolved
Hide resolved
Important Auto Review SkippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the To trigger a single review, invoke the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
Co-authored-by: Sai Kumar Battinoju <[email protected]>
Quality Gate passedIssues Measures |
PR Description
Onboard new destination ninetailed.
This destination uses a npm package and not any
cdn
script .Hence we expect users to directly load it themselves and we would check for
window.ninetailed
obejct if it is present we will direct make calls to that object.This destination supports
identify
,track
, andpage
calls.Linear task (optional)
Linear task link
INT-295
Cross Browser Tests
Please confirm you have tested for the following browsers:
Sanity Suite
Security