Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: onboard new destination ninetailed #1617

Merged
merged 9 commits into from
Feb 28, 2024
Original file line number Diff line number Diff line change
Expand Up @@ -154,6 +154,8 @@ import {
SpotifyPixelDirectoryName,
CommandBarDisplayName,
CommandBarDirectoryName,
NinetailedDisplayName,
NinetailedDirectoryName,
} from './destinationNames';

// The destination directory name is used as the destination SDK file name in CDN
Expand Down Expand Up @@ -235,6 +237,7 @@ const destDisplayNamesToFileNamesMap: Record<string, string> = {
[SprigDisplayName]: SprigDirectoryName,
[SpotifyPixelDisplayName]: SpotifyPixelDirectoryName,
[CommandBarDisplayName]: CommandBarDirectoryName,
[NinetailedDisplayName]: NinetailedDirectoryName,
};

export { destDisplayNamesToFileNamesMap };
Original file line number Diff line number Diff line change
Expand Up @@ -306,3 +306,7 @@
DISPLAY_NAME as CommandBarDisplayName,
DIR_NAME as CommandBarDirectoryName,
} from './integrations/CommandBar/constants';
export {
DISPLAY_NAME as NinetailedDisplayName,
DIR_NAME as NinetailedDirectoryName,

Check warning on line 311 in packages/analytics-js-common/src/constants/destinationNames.ts

View check run for this annotation

Codecov / codecov/patch

packages/analytics-js-common/src/constants/destinationNames.ts#L309-L311

Added lines #L309 - L311 were not covered by tests
} from './integrations/Ninetailed/constants';
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
const DIR_NAME = 'Ninetailed';
const NAME = 'NINETAILED';
const DISPLAY_NAME = 'Ninetailed';

Check warning on line 3 in packages/analytics-js-common/src/constants/integrations/Ninetailed/constants.ts

View check run for this annotation

Codecov / codecov/patch

packages/analytics-js-common/src/constants/integrations/Ninetailed/constants.ts#L1-L3

Added lines #L1 - L3 were not covered by tests

const DISPLAY_NAME_TO_DIR_NAME_MAP = { [DISPLAY_NAME]: DIR_NAME };
const CNameMapping = {

Check warning on line 6 in packages/analytics-js-common/src/constants/integrations/Ninetailed/constants.ts

View check run for this annotation

Codecov / codecov/patch

packages/analytics-js-common/src/constants/integrations/Ninetailed/constants.ts#L5-L6

Added lines #L5 - L6 were not covered by tests
[NAME]: NAME,
Ninetailed: NAME,
ninetailed: NAME,
NineTailed: NAME,
};

export { NAME, CNameMapping, DISPLAY_NAME_TO_DIR_NAME_MAP, DISPLAY_NAME, DIR_NAME };

Check warning on line 13 in packages/analytics-js-common/src/constants/integrations/Ninetailed/constants.ts

View check run for this annotation

Codecov / codecov/patch

packages/analytics-js-common/src/constants/integrations/Ninetailed/constants.ts#L13

Added line #L13 was not covered by tests
Original file line number Diff line number Diff line change
Expand Up @@ -74,8 +74,9 @@ const clientToServerNames = {
TIKTOK_ADS: 'TikTok Ads',
ACTIVE_CAMPAIGN: 'ActiveCampaign',
SPRIG: 'Sprig',
SPOTIFYPIXEL:'Spotify Pixel',
COMMANDBAR:'CommandBar',
SPOTIFYPIXEL: 'Spotify Pixel',
COMMANDBAR: 'CommandBar',
NINETAILED: 'Ninetailed',
};

export { clientToServerNames };
Original file line number Diff line number Diff line change
Expand Up @@ -77,6 +77,7 @@ const configToIntNames = {
SPRIG: 'Sprig',
SPOTIFYPIXEL: 'SpotifyPixel',
COMMANDBAR: 'CommandBar',
NINETAILED: 'Ninetailed',
};

export { configToIntNames };
Original file line number Diff line number Diff line change
Expand Up @@ -75,6 +75,8 @@
import { CNameMapping as Sprig } from '../../constants/integrations/Sprig/constants';
import { CNameMapping as SpotifyPixel } from '../../constants/integrations/SpotifyPixel/constants';
import { CNameMapping as CommandBar } from '../../constants/integrations/CommandBar/constants';
import { CNameMapping as Ninetailed } from '../../constants/integrations/Ninetailed/constants';

Check warning on line 78 in packages/analytics-js-common/src/v1.1/utils/integration_cname.js

View check run for this annotation

Codecov / codecov/patch

packages/analytics-js-common/src/v1.1/utils/integration_cname.js#L78

Added line #L78 was not covered by tests

// for sdk side native integration identification
// add a mapping from common names to index.js exported key names as identified by Rudder
const commonNames = {
Expand Down Expand Up @@ -113,6 +115,7 @@
...Lytics,
...Mixpanel,
...MoEngage,
...Ninetailed,
...Optimizely,
...Pendo,
...PinterestTag,
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,95 @@
import Ninetailed from '../../../src/integrations/Ninetailed/browser';

saikumarrs marked this conversation as resolved.
Show resolved Hide resolved
afterAll(() => {
jest.restoreAllMocks();
saikumarrs marked this conversation as resolved.
Show resolved Hide resolved
});
const destinationInfo = {
areTransformationsConnected: false,
destinationId: 'sample-destination-id',
};
window.ninetailed = {};

describe('Ninetailed page', () => {
saikumarrs marked this conversation as resolved.
Show resolved Hide resolved
let nt;
beforeEach(() => {
nt = new Ninetailed({}, { loglevel: 'DEBUG' }, destinationInfo);
window.ninetailed.page = jest.fn();
});

test('send pageview', () => {
nt.page({
message: {
context: {},
properties: {
category: 'test cat',
path: '/test',
url: 'http://localhost',
referrer: '',
title: 'test page',
testDimension: 'abc',
isRudderEvents: true,
},
},
});
expect(window.ninetailed.page.mock.calls[0][0]).toEqual({
category: 'test cat',
path: '/test',
url: 'http://localhost',
referrer: '',
title: 'test page',
testDimension: 'abc',
isRudderEvents: true,
});
});
});

describe('Ninetailed Track event', () => {
let nt;
beforeEach(() => {
nt = new Ninetailed({}, { loglevel: 'DEBUG' }, destinationInfo);
window.ninetailed.track = jest.fn();
});
test('Testing Track Custom Events', () => {
const properties = {
customProp: 'testProp',
checkout_id: 'what is checkout id here??',
event_id: 'purchaseId',
order_id: 'transactionId',
value: 35.0,
shipping: 4.0,
isRudderEvents: true,
};
nt.track({
message: {
context: {},
event: 'Custom',
properties,
},
});
expect(window.ninetailed.track.mock.calls[0][0]).toEqual('Custom');
expect(window.ninetailed.track.mock.calls[0][1]).toEqual(properties);
});
});
describe('Ninetailed Identify event', () => {
let nt;
beforeEach(() => {
nt = new Ninetailed({}, { loglevel: 'DEBUG' }, destinationInfo);
window.ninetailed.identify = jest.fn();
});
test('Testing Identify Custom Events', () => {
const traits = {
email: '[email protected]',
isRudderEvents: true,
};
nt.identify({
message: {
userId: 'rudder01',
context: {
traits,
},
},
});
expect(window.ninetailed.identify.mock.calls[0][0]).toEqual('rudder01');
expect(window.ninetailed.identify.mock.calls[0][1]).toEqual(traits);
});
});
Original file line number Diff line number Diff line change
@@ -0,0 +1,57 @@
/* eslint-disable no-underscore-dangle */
/* eslint-disable class-methods-use-this */
import {
NAME,
DISPLAY_NAME,
} from '@rudderstack/analytics-js-common/constants/integrations/Ninetailed/constants';
import Logger from '../../utils/logger';

const logger = new Logger(DISPLAY_NAME);
class Ninetailed {
constructor(config, analytics, destinationInfo) {
if (analytics.logLevel) {
logger.setLogLevel(analytics.logLevel);

Check warning on line 13 in packages/analytics-js-integrations/src/integrations/Ninetailed/browser.js

View check run for this annotation

Codecov / codecov/patch

packages/analytics-js-integrations/src/integrations/Ninetailed/browser.js#L13

Added line #L13 was not covered by tests
}
this.analytics = analytics;
this.organisationId = config.organisationId;
this.environment = config.environment;
this.name = NAME;
({
shouldApplyDeviceModeTransformation: this.shouldApplyDeviceModeTransformation,
propagateEventsUntransformedOnError: this.propagateEventsUntransformedOnError,
destinationId: this.destinationId,
} = destinationInfo ?? {});
}

init() {
// We expect the customer to load the SDK through NPM package
// Docs: https://docs.ninetailed.io/for-developers/experience-sdk/getting-started
saikumarrs marked this conversation as resolved.
Show resolved Hide resolved
}

isLoaded() {
return !!window.ninetailed;

Check warning on line 32 in packages/analytics-js-integrations/src/integrations/Ninetailed/browser.js

View check run for this annotation

Codecov / codecov/patch

packages/analytics-js-integrations/src/integrations/Ninetailed/browser.js#L32

Added line #L32 was not covered by tests
}

isReady() {
return this.isLoaded();

Check warning on line 36 in packages/analytics-js-integrations/src/integrations/Ninetailed/browser.js

View check run for this annotation

Codecov / codecov/patch

packages/analytics-js-integrations/src/integrations/Ninetailed/browser.js#L36

Added line #L36 was not covered by tests
}

identify(rudderElement) {
const { message } = rudderElement;
const { userId, traits, context } = message;
saikumarrs marked this conversation as resolved.
Show resolved Hide resolved
const userTraits = { ...traits, ...context?.traits };
window.ninetailed.identify(userId, userTraits);
}
track(rudderElement) {
const { message } = rudderElement;
const { properties, event } = message;
window.ninetailed.track(event, properties);
}
page(rudderElement) {
const { message } = rudderElement;
const { properties } = message;
window.ninetailed.page(properties);
}
}

export default Ninetailed;
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
export { default as Ninetailed } from './browser';

Check warning on line 1 in packages/analytics-js-integrations/src/integrations/Ninetailed/index.js

View check run for this annotation

Codecov / codecov/patch

packages/analytics-js-integrations/src/integrations/Ninetailed/index.js#L1

Added line #L1 was not covered by tests
Original file line number Diff line number Diff line change
Expand Up @@ -75,6 +75,7 @@
import * as Sprig from './Sprig';
import * as SpotifyPixel from './SpotifyPixel';
import * as CommandBar from './CommandBar';
import * as Ninetailed from './Ninetailed';

Check warning on line 78 in packages/analytics-js-integrations/src/integrations/index.js

View check run for this annotation

Codecov / codecov/patch

packages/analytics-js-integrations/src/integrations/index.js#L78

Added line #L78 was not covered by tests
// the key names should match the destination.name value to keep parity everywhere
// (config-plan name, native destination.name , exported integration name(this one below))

Expand Down Expand Up @@ -156,6 +157,7 @@
ACTIVE_CAMPAIGN: ActiveCampaign.default,
SPRIG: Sprig.default,
SPOTIFYPIXEL: SpotifyPixel.default,
NINETAILED: Ninetailed.default,
};

export { integrations };
Loading